Needs review
Project:
XRDS Simple
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
8 Apr 2011 at 07:36 UTC
Updated:
29 Jan 2012 at 00:20 UTC
Seeing these notices on a site during OpenID login. I haven't debugged beyond seeing watchdog calls while profiling and querying the dblog table, apologies for lack of detail:
----------------------------------+-----------------+------------+
| 2046 | 0 | php | %type: %message in %function (line %line of %file). | a:5:{s:5:"%type";s:6:"Notice";s:8:"%message";s:25:"Undefined index: expires";s:9:"%function";s:22:"xrds_simple_document()";s:5:"%file";s:82:"/mnt/www/example/docroot/sites/all/modules/contrib/xrds_simple/xrds_simple.module";s:5:"%line";i:72;} | 3 | | http://example.com/user/246318/xrds | | 127.0.0.1 | 1302247406 |
| 2045 | 0 | php | %type: %message in %function (line %line of %file). | a:5:{s:5:"%type";s:6:"Notice";s:8:"%message";s:22:"Undefined index: type";s:9:"%function";s:22:"xrds_simple_document()";s:5:"%file";s:82:"/mnt/www/example/docroot/sites/all/modules/contrib/xrds_simple/xrds_simple.module";s:5:"%line";i:66;} | 3 | | example.com/user/246318/xrds | | 127.0.0.1 | 1302247406 |
| 2044 | 0 | php | %type: %message in %function (line %line of %file). | a:5:{s:5:"%type";s:6:"Notice";s:8:"%message";s:28:"Undefined index: namespaces";s:9:"%function";s:22:"xrds_simple_document()";s:5:"%file";s:82:"/mnt/www/example/docroot/sites/all/modules/contrib/xrds_simple/xrds_simple.module";s:5:"%line";i:62;} | 3 | | http://example.com/user/246318/xrds | | 127.0.0.1 | 1302247406 |
| 2043 | 0 | php | %type: %message in %function (line %line of %file). | a:5:{s:5:"%type";s:6:"Notice";s:8:"%message";s:25:"Undefined index: expires";s:9:"%function";s:22:"xrds_simple_document()";s:5:"%file";s:82:"/mnt/www/example/docroot/sites/all/modules/contrib/xrds_simple/xrds_simple.module";s:5:"%line";i:72;} | 3 | | http://example.com/user/246318/xrds | | 127.0.0.1 | 1302247406 |
| 2042 | 0 | php | %type: %message in %function (line %line of %file). | a:5:{s:5:"%type";s:6:"Notice";s:8:"%message";s:22:"Undefined index: type";s:9:"%function";s:22:"xrds_simple_document()";s:5:"%file";s:82:"/mnt/www/example/docroot/sites/all/modules/contrib/xrds_simple/xrds_simple.module";s:5:"%line";i:66;} | 3 | | http://example.com/user/246318/xrds | | 127.0.0.1 | 1302247406 |
| 2041 | 0 | php | %type: %message in %function (line %line of %file). | a:5:{s:5:"%type";s:6:"Notice";s:8:"%message";s:28:"Undefined index: namespaces";s:9:"%function";s:22:"xrds_simple_document()";s:5:"%file";s:82:"/mnt/www/example/docroot/sites/all/modules/contrib/xrds_simple/xrds_simple.module";s:5:"%line";i:62;} | 3 | | http://example.com/user/246318/xrds
Comments
Comment #1
damien_vancouver commentedThis is more a documentation issue than a bug per se. XRDS Simple has no docs which say that you should set these keys in hook_xrds(). OpenID Server for 6.x does not set them... but XRDS Simple throws errors from them not being there.
It needs some isset() calls to stop the errors, and a proper README.txt.
At the present though, this module is effecitvely abandoned. The maintaner is AWOL and not responding to issue queues. I am trying to get authorized to co-maintain, and if I am, I'll fix this in 6.x too with the isset and README.txt.
Comment #2
damien_vancouver commentedI backported the isset()'s from 7.x and this is now fixed: ff99f07. and in 6.x-1.x-dev.
Errors are gone for me. If someone can confirm, I'll make a 6.x-1.1 release with the fix included.
I also added the README.txt, LICENSE.txt and missing function comments, all backported from 7.x - these can also be found / reviewed in 6.x-1.x-dev