Looks like there's method compatibility warnings with the most recent version of views:

    Strict warning: Declaration of flag_handler_field_ops::pre_render() should be compatible with that of views_handler_field::pre_render() in _registry_check_code() (line 2811 of includes/bootstrap.inc).

    Strict warning: Declaration of flag_handler_relationship_content::ui_name() should be compatible with that of views_handler::ui_name() in require_once() (line 84 of sites/all/modules/flag/includes/flag_handler_relationships.inc).

    Strict warning: Declaration of flag_handler_relationship_content::options_validate() should be compatible with that of views_handler::options_validate() in require_once() (line 84 of sites/all/modules/flag/includes/flag_handler_relationships.inc).

    Strict warning: Declaration of flag_handler_relationship_counts::ui_name() should be compatible with that of views_handler::ui_name() in require_once() (line 178 of sites/all/modules/flag/includes/flag_handler_relationships.inc).
CommentFileSizeAuthor
#16 flag-strict-1119842-16.patch1.68 KBrjay
#14 1119842-14-views-strict-6.x-backport.patch2.01 KBjoelpittet
#1 flag-strict-1-1119842.patch1.99 KBduellj
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

duellj’s picture

duellj CreditAttribution: duellj commented
FileSize
flag-strict-1-1119842.patch1.99 KB

Patch attached to fix strict warnings

duellj’s picture

duellj CreditAttribution: duellj commented
Status: Active » Needs review
TimelessDomain’s picture

TimelessDomain CreditAttribution: TimelessDomain commented

patch worked for me - thanks.

TimelessDomain’s picture

TimelessDomain CreditAttribution: TimelessDomain commented

Not related to this issue
the exposed filter for "Flags: Flagged" does not have an "-Any-" option so a view w/ this filter can only display flagged or not flagged content (not both). this should be fixed

update#1: the "-Any-" selection of an exposed filter for "Flags: Flagged" is available when your view the view, but not when you edit the view. therefore you can't set the exposed "Flags: Flagged" filter to "-Any-" by default

update#2: #1126724: -Any- option missing from exposed filter for Flags: Flagged (@duellj - updated accordingly)

duellj’s picture

duellj CreditAttribution: duellj commented

@TimelessDomain:

Thanks or the review. You should open up a new issue for the problem you listed in #4. This issue is just for strict warnings in flags/views integration.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs review » Reviewed & tested by the community

Patch works for me as well!

lyricnz’s picture

lyricnz CreditAttribution: lyricnz commented

Works for me too.

kolier’s picture

kolier CreditAttribution: kolier commented

Working +1.

Cyberwolf’s picture

Cyberwolf CreditAttribution: Cyberwolf commented

Subscribing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented

This resolved the errors for me too.

Ingmar’s picture

Ingmar CreditAttribution: Ingmar commented

Thank you very much!

quicksketch’s picture

quicksketch
he/him
CreditAttribution: quicksketch commented
Status: Reviewed & tested by the community » Fixed

Most of this patch was included in the fix from #1119842: Strict warnings with Views 3.x, but I added the change to flag_handler_field_ops.inc in this patch, since that was not included in the previous patch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Issue summary: View changes
FileSize
1119842-14-views-strict-6.x-backport.patch2.01 KB

Don't know if this needs a backport to 6.x but here is the patch nonetheless.

stewart.adam’s picture

stewart.adam CreditAttribution: stewart.adam commented

Note - the 6.x patch above doesn't fix all warnings for options_validate since the signature in Drupal 6 has $form passed by value, not reference. 

+  function options_validate(&$form, &$form_state) {

should read:

+  function options_validate($form, &$form_state) {
rjay’s picture

rjay CreditAttribution: rjay at North Studio commented
Version: 7.x-2.x-dev » 6.x-2.x-dev
Status: Closed (fixed) » Needs review
FileSize
flag-strict-1119842-16.patch1.68 KB

This is an update of the patch from #14, without the modification to the signature of the options_validate method.

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs review » Fixed

Thanks!

Committed.

  • joachim committed 87c4d0a on 6.x-2.x authored by duellj 
    Issue #1119842 by duellj, joelpittet, rjay: Fixed strict warnings with...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.