Product titles longer than 128 are lost from order [#1113644]

Just saw this entry in the watchdog for a test order and noticed the order (though completed) had no products/line items shown in it.

Looks to me like the database fields for a product/line item title are limited to 128 chars long, so the code should check title lengths and truncate if necessary before trying to insert into the database. And perhaps 128 should be bumped up.

Data too long for column 'title' at row 1 query: INSERT INTO uc_order_products (order_id, nid, title, manufacturer, model, qty, cost, price, weight, data) VALUES (60, 47824, 'Clap! Shake! Play! Sing! Creating Musical Storytimes to Encourage Emergent Literacy | Camarena Memorial Public Library - Calexico', '', 'placeholder', 1, 0, 0, 0, 'a:4:{s:17:\"uc_signup_enabled\";i:1;s:10:\"attributes\";a:1:{s:7:\"Pricing\";a:1:{i:0;s:12:\"Out of state\";}}s:9:\"shippable\";s:1:\"0\";s:6:\"module\";s:10:\"uc_product\";}') in /home/adam/projects/ip/app/drupal/includes/common.inc on line 3538.

Comment	File	Size	Author
#13	1113644-uc_order_product-title-length.patch	1.6 KB	longwave
#13
#7	1113644-6-6.x-2.4.patch	1.57 KB	adamdicarlo
#7
#7	1113644-6-6.x-2.x.patch	1.8 KB	adamdicarlo
#7
#3	1113644.patch	1.48 KB	TR
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

TR CreditAttribution: TR commented 1 April 2011 at 22:18

The column {uc_order_products}.title is taken from {node}.title, so the schema should have been defined the same. In fact {node}.title used to be a varchar(128) back in Drupal 5 when Ubercart was first written, but was changed in Drupal 6 to be a varchar(255). I guess the Ubercart developers back then didn't get the memo, which is why {uc_order_product}.title is still at 128.

I'll create a patch to increase the size of {uc_order_products}.title to varchar(255). No sense in trying to make it longer than that because you won't be able to create a product node with a title longer than that.

Comment #2

adamdicarlo CreditAttribution: adamdicarlo commented 1 April 2011 at 22:31

Weird, but interesting story behind that. Thanks for the fast response!

Comment #3

TR CreditAttribution: TR commented 1 April 2011 at 23:20

Status:

Active

» Needs review

File	Size
1113644.patch	1.48 KB

Here's the patch. I tested it and it worked to update my D6 test site.

Comment #4

1 April 2011 at 23:31

Status:

Needs review

» Needs work

The last submitted patch, 1113644.patch, failed testing.

Comment #5

TR CreditAttribution: TR commented 1 April 2011 at 23:39

(Yeah, bot doesn't work on fixed-point branches like 6.x-2.4).

Comment #7

adamdicarlo CreditAttribution: adamdicarlo commented 4 April 2011 at 18:14

File	Size
1113644-6-6.x-2.x.patch	1.8 KB

1113644-6-6.x-2.4.patch	1.57 KB

Hmm, the patch is failing to apply for me. I've tried applying to 6.x-2.4 (from the official release), and to 6.x-2.x from git.

adam@mrwalrus:~/projects/..../modules/contrib/ubercart$ patch -p0 < 1113644.patch
patching file b/uc_order/uc_order.install
Hunk #1 FAILED at 359.
Hunk #2 FAILED at 456.
Hunk #3 FAILED at 1005.
3 out of 3 hunks FAILED -- saving rejects to file b/uc_order/uc_order.install.rej

Here is the patch rerolled against both 6.x-2.4 and 6.x-2.x. The 6.x-2.4 one is a bit of a frankenstein since it includes a one-liner hook_update_N() that is in 2.x but not 2.4. Heh. This way that update won't get skipped.

Edit: Aw man, how'd this end up as comment #7? Thought it'd be #6. Oh well.