Height 100% in naked structure stylesheet [#1113616]

On lines 285 and 290, the advanced_forum.naked.structure.css stylesheet has a height:100% value for .forum-post-wrapper and .forum-post-info, respectively. I'm not sure what this is supposed to do, but my understanding of the horribly flawed standard treatment of percentages in the height attribute is that 100% means 100% of the browser window unless there has been a specified height in some containing block, such as 420px etc. Now, for all I know, some of the default styles use a specified height like this so it makes sense for them, but naked does not, and I'm using a custom style. Admittedly this doesn't seem to affect my site at all unless I've triggered quirks mode, so I may just be more confused about the height attribute than I even realize.

Comments

Comment #1

Michelle

she/her

English

Wisconsin, USA

CreditAttribution: Michelle commented 1 April 2011 at 21:21

Category:	bug	» task
Status:	Active	» Postponed (maintainer needs more info)

I don't consider something that is working to be a bug. The structure of the forum posts took many months and several themers to get something that works across browsers without things jumping out of the Author Pane. I'm not going to mess with it unless someone submits a patch that doesn't break it.

Michelle

Comment #2

meustrus CreditAttribution: meustrus commented 1 April 2011 at 21:55

Well, I think it would be expedient if we could hear why this piece is here by the themer responsible for this particular code. I think that the attribute would always either do nothing, or break the page, but I wouldn't know if it has some special behavior in IE6 for example. It certainly isn't major enough that I think it needs to be done right away, though.

Comment #3

Michelle

she/her

English

Wisconsin, USA

CreditAttribution: Michelle commented 1 April 2011 at 22:10

If you want to trace it back and figure out who did it, feel free. If you want to patch it, feel free. Personally, I'm not going to spend more time on this. It was agony to get it working the first time around and it's working and has been working for some time. I'm going to spend my time on the things that aren't working.

Michelle

Comment #5

cbozman CreditAttribution: cbozman commented 21 November 2011 at 23:21

I was having a similar problem in Drupal 7 with the "Naked" structure. I overrode the style in my own style sheet and set the height of the divs (that were 100%) to "auto". Problem solved.

Comment #6

Geldora CreditAttribution: Geldora commented 5 December 2011 at 15:12

I had the problems too.

It's strange, as I am using AF quite long time and had not any problems at all... But suddently, all elements with height: 100% got bigger. They have took much more than 100% of their text contents. For example, the ribbon where date and № of comment is located, suddently became 200 px instead of 20px normally.

I had to manually remove all height: 100% from module style-sheets. Then everything goes normal.