If you add a new menu and then add a new menu link to that menu immediately afterwards, the XML Sitemap settings fieldset doesn't appear on the form. You have to clear the cache first.

This is causing the xmlsitemap_menu tests to fail.

The problem is that the entity cache hasn't been updated to reflect the new menu yet. Since XML Sitemap is defining the menu link entity itself, I guess that means it's up to it to clear the cache when menus change. That's what the attached patch does.

CommentFileSizeAuthor
#3 xmlsitemap-menu-clear-entity-cache-1112770-3.patch1.29 KBDavid_Rothstein
#1 xmlsitemap-menu-clear-entity-cache-1112770-1.patch1.28 KBDavid_Rothstein
xmlsitemap-menu-clear-entity-cache.patch1.28 KBDavid_Rothstein
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented
FileSize
xmlsitemap-menu-clear-entity-cache-1112770-1.patch1.28 KB

Fixing a silly typo in the code comments.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

Good catch!

Please for my code style sake add a blank line in between the new chunks and their respective previous code. :)

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented
FileSize
xmlsitemap-menu-clear-entity-cache-1112770-3.patch1.29 KB

Done :)

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Needs review » Fixed

Committed to Git:
http://drupalcode.org/project/xmlsitemap.git/commit/7a94e4c

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.