In #808518: API change: Split mail preparation from sending, Mime Mail module is preparing an API change. Now mimemail() returns a boolean but after this API change will return an array with the whole message. The actual boolean will be included in return array as key "result".
Fro, PHPDoc:
* @return
* An array containing the MIME encoded message, including headers and body.
Simplenews must adapt to the new Mime Mail API.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | simplenews_1112310_6.x-2.x_Mimemail_API_change.patch | 1.38 KB | simon georges |
| #1 | simplenews_6.x-1.x_1112310_01.patch | 1.35 KB | sgabe |
| #1 | simplenews_6.x-2.x_1112310_01.patch | 1.39 KB | sgabe |
Comments
Comment #1
sgabe commentedSee the attached patches for both D6 branches with backwards compatibility for previous versions of Mime Mail.
Comment #2
simon georges commentedThe backwards compatibility seems to be more tricky: if returning a boolean, all keys needed for the watchdog message are lost. But I'll see your point, and will work on the basis of your first patches.
Comment #3
sgabe commentedOh, I see. Sorry I wasn't thorough enough...
Comment #4
simon georges commentedNo problem, at least you told us about your api modifications.
What about the 7.x version ? (I'll work on the 6.x patches this week-end).
Comment #5
sgabe commentedThis doesn't valid for the 7.x version since on Drupal 7 you can use drupal_mail() to send messages with any mail system, so mimemail() is deprecated.
Comment #6
simon georges commentedCan somebody review the patch ?
Comment #7
sgabe commentedI think it's perfect.
Comment #8
simon georges commentedCommitted in 6.x-1.x and 6.x-2.x.
No need to port it to 7.x-1.x.
@sgabe, thanks again for the heads up.