After fix of issue #855392: Use CTools' export-ui I have following problem.

During the tests run after creation of the endpoint following exception is thrown:
Undefined property: stdClass::$export_type Notice export.inc 151 ctools_export_crud_save()

CommentFileSizeAuthor
#1 1111252-create-endpoint-exception-tests-d7.patch832 bytesygerasimov

Comments

ygerasimov’s picture

ygerasimov commented
Status: Active » Needs review
StatusFileSize
new 1111252-create-endpoint-exception-tests-d7.patch832 bytes

Here is patch.

There is no such problem on D6 so there will be no porting.

kylebrowning’s picture

kylebrowning commented
Status: Needs review » Needs work

I think these should be set based upon whether it exists in the database,

Maybe i dont understand ctools correctly, but checkout this crud save

http://drupalcode.org/project/ctools.git/blob/eaa4a567b8157ef17ca13d850a...

If im wrong, just tell me and ill gladly commit :)

ygerasimov’s picture

ygerasimov commented

In our test case we create new endpoint so it does not exist in database.

The problem in our case is in line 151 as we do not define export_type for entity and this trows exception.

Surely we can think about propose to add additional check in ctools for this line. 

if (isset($object->export_type) && $object->export_type & EXPORT_IN_DATABASE) {

But this part I am not sure. Please share your opinion.

kylebrowning’s picture

kylebrowning commented
Status: Needs work » Closed (fixed)

I fixed this in 6.x-3.x as well