Ubercart Discounts

This patch adds a very simple sub-module to UberPOS that provides integration with UC Discounts Alt. The module adds a button DISC and a command DC. When preceded by a discount code, the commant attempts to apply the discount code to the order. If no code is provided, it tries to apply any possible codeless discounts to the order. UC Discounts ALT does all the heavy lifting.

This is an updated patch. Re-applies and re-calculates order-wide discounts as products are added/removed.

Committed!

Thanks a lot for this!

However, "[re-applying]and [re-calculating] order-wide discounts as products are added/removed" does not work 100% yet. If you have site wide discounts (for certain user roles, say), this does not happen as the implementation of hook_order checks for presence of discount codes before it tries to apply discounts. For site wide discounts, there is no discount code, so nothing happens.

To fix this, the function up_discounts_order should simply be:

/**
 * Implementation of hook_order().
 */
function up_discounts_order($op, &$order, $arg2) {
  global $up_discounts_recalc;
  if ($op == 'save') {
    up_discounts_process($order);
  }
}

Unfortunately, if you do this and no discounts were applied, which is usually the case, a warning message appears. This warning message needs to be suppressed (I think), so the function up_discounts_process needs to be rewritten to:

function up_discounts_process($order, $discount_code = '') {
  $codes = array();
  if ($discount_code) {
    $codes[] = $discount_code;
  }
  if (!empty($order->uc_discounts_codes)) {
    $codes += $order->uc_discounts_codes;
  }
  $codes = implode("\r", $codes);

  uc_discounts_order_pane_callback(t('Apply discounts'), array('order_id' => $order->order_id, 'uc-discounts-codes' => $codes));
  
  // Clear status messages.
  drupal_get_messages('status', TRUE);
  
  // Display errors.
  $errors = drupal_get_messages('error', TRUE);
  $warnings = drupal_get_messages('warning', TRUE);
  $message .= implode(' ', $errors['error']);
  // since we're attempting to apply discounts every time the order is saved,
  // it's not a problem if no discount is applied. Suppress the warning
  // that says no discounts were applied
  $relevant_warnings = array();
  foreach($warnings['warning'] as $warning) {
    if($warning == t('The code(s) did not yield a discount for this order.')) {
      continue;
    };
    $relevant_warnings[] = $warning;
  };
  $message .= implode(' ', $relevant_warnings);
  //$message .= implode(' ', $warnings['warning']);
  if ($message) 
    uberpos_clear_message($message);
}

The drawback to this suppression is that if a user explicitly calls the DC command and nothing happens, no warning appears. There's probably a (convoluted) way around that, however, but since I don't need it, I haven't implemented it.

Could the changes above please be added to the code for the up_discounts module?

Thanks!

It's also probably a good idea to apply discounts in the uberpos code itself, using the new uc_discounts_apply() function (see http://drupal.org/node/1166912)

That all makes sense to me. Thanks for getting jrust to add that api function! I should get this reviewed and committed this weekend.

Now that there is a uc_discounts_apply() function in UC Discounts Alt (albeit only in the dev version) the code needs to be patched according to the attached, ehm, patch.

Woops. There was a typo in the patch. Sorry. Here's the fixed one.

Has this last patch been committed?