I am using the Media module mainly to add images to my content. I need also to add captions to those images. The idea of having custom fields – like in Content Types – it's very good but these fields are not visualized according to the settings in the Image media type settings page.

So far, I have found that this is related to a function named media_get_file_without_label() (called in media.filter.inc). So far, I am trying to replace this function call – on line 173 of media.filter.inc – with this different one:

field_attach_view('media', $media_obj, $media['view_mode'], null);

So this is not showing just the File field without label but all the fields in this object.

I am still missing some parts (for instance I would like to have this themed as an entity and not as separated ones per field and I also would like to have this custom fields in the editing window when I upload files using WYSIWYG…).

I will be glad to provide what I'm doing as patches but I would like to confirm that I am doing something usable…

Comments

tomgf’s picture

StatusFileSize
new1.46 KB

Alright, I have worked a bit more on this. This is what I have done, so far:

  1. changed from media_get_file_without_label to field_attach_view
  2. produced a themable output using the function theme_media_file
  3. registered the function theme_media_file

With these changes, I have the possibility of showing / hiding the custom fields from the uploaded files.

tomgf’s picture

StatusFileSize
new3.13 KB

With this new patch, the custom fields are shown on the embedding media form. The changes are on the media_media_format_form_prepare_alter function.

The missing parts:

  1. update the proper tables on the DB when submitting
  2. showing this values on the WYSIWYG edit window (so far I just see the image)

I would be thankful is somebody could point me in the right direction here: I can not find which function is responding to the submit of this form…

skessler’s picture

Issue tags:+accessibility

subscribe.

animelion’s picture

subscribe

tomgf’s picture

StatusFileSize
new5.38 KB

I have done another step: the custom fields are updated when submitting the form. It implies an special method because this form is just dumping json into the body editing field (not doing any server request).

What I did was to intercept this and call an extra function that is posting the form values to a new function – function media_update_ajax() – that takes care of updating the fields.

It has probably many glitches (and perhaps bad coding) but so far is solving my problem of editing the custom fields when adding the images. I'd be glad to hear some comments.

My next step will be to reflect this changes – custom fields, etc. – inside the WYSIWYG body…

Extra note: this patch was generated using the --no-prefix option, so it can be applied by using patch -p0 < name.patch

tomgf’s picture

StatusFileSize
new5.38 KB

I will document some of the process I am following. Perhaps this is useful to others.

  1. I have added to my Image Media Type (see admin/config/media/types) two extra fields:
    • field_img_alt
    • field_img_title
  2. I have assured that this fields are visible on the Display type I will use (i.e. admin/config/media/types/manage/image/display/media_small)
  3. I have modified my theme (as I have added a theme_media_file function, the output is themable), using a preprocess function to prepare the #markup and use these two fields – field_img_alt and field_img_title – as the image ALT and Title attributes:
    <?php
    function THEME_preprocess_media_file(&$variables) {

     
    // Add ALT and title to images 
     
    if ($variables['file']['#bundle'] == 'image') {

       
    // Alternate text
       
    $alt $variables['field_img_alt'][0]['#markup'];
        unset(
    $variables['field_img_alt']);

       
    // Title attribute
       
    $title = $variables['field_img_title'][0]['#markup'];
        unset(
    $variables['field_img_title']);
     
       
    // Replace
       
    $string = $variables['file'][0]['#markup'];
       
    $pattern = '/<span[^>]+> +<img src="([^"]+)" ?\/><\/span>/i';
       
    $replacement = '<img src="$1" alt="' . $alt . '" title="' . $title . '" />';

       
    $variables['file'][0]['#markup'] = preg_replace($pattern, $replacement, $string);
      }

    }
    ?>

    Note: the span tags are created by the Styles module… Surely there is a better way of taking them off, but for the time being I just preg_replace-them.

Finally, I attach here a new version of the patch (just a tiny difference as I have missed an space).

cartagena’s picture

Thanks, tomgf! I do need this and will test it next week--after my site goes live. Still to much to do to get ti out by the deadline. After that I'll be back! Thanks again.

tomgf’s picture

You're welcome, @cartagena. Check what I have posted in relation to stripping media tags before creating trimmed versions of the content: #1113088: Strip media before trimming summary.

I have to use that too in order to visualize my content the way I wanted to.

cartagena’s picture

This is great! Not only have I had the same need, but I am happy to see how you built it. I'm not a programmer but I'm working to learn php and js. I can study your code and understand what it's doing and why. And maybe someday write a module (a very simple one!) myself and help someone else out! Thanks again!

emackn’s picture

this seems to be more of a workaround then a fix.

One would think that the additional fields added to a media asset should appear on a content type that the asset is used in.

balintk’s picture

Subscribe.

sreynen’s picture

Status:Active» Needs work

Regular expressions to parse already-rendered HTML isn't a real solution. That happens elsewhere in media, and it's a horrible mistake. Let's not repeat that.

What I did instead was attach the full parsed JSON object to the $media object in media_get_file_without_label(). To do that, I changed the end of media_token_to_markup() to this:

  $data = array(
    'settings' => $settings,
    'json' => $media,
  );

  $file_field = media_get_file_without_label($media_obj, $media['view_mode'], $data);

And then changed media_get_file_without_label() to this:

function media_get_file_without_label($media, $view_mode, $data = array()) {
  $settings = $data['settings'];
  $instance = field_info_instance('media', 'file', $media->type);
  $format = field_get_display($instance, $view_mode, $media);
  $format['label'] = 'hidden';
  $format['settings'] = array_merge($format['settings'], $settings);
  $media->override = $settings;
  $media->json = $data['json'];
  return field_view_field('media', $media, 'file', $format);
}

Then in whatever styles theme function is actually producing the HTML, $variables['instance']->object->json contains everything passed in the JSON.

Ideally $media->override would be more general purpose so we could keep all this data in one place, but that would require changes to everywhere it's used.

FrequenceBanane’s picture

subscribe

kingjohnnet’s picture

subscribe

animelion’s picture

subscribe

yareckon’s picture

hi media module core folks... could you weigh in on the wisdom of this approach for allowing additional fields to be rendered as above?

abelb’s picture

subscribe

betz’s picture

subscribe

victoriachan’s picture

subscribe

renat’s picture

Subscribe

arthurf’s picture

Status:Needs work» Closed (duplicate)

This is a super important issue. The solution needs to handle fields on files which is something that the 2.x is starting to address. This issue http://drupal.org/node/1213252 has the start of making the fields on files editable. I'm closing this issue to focus discussion over there.