In ctools_modal_form_render() there is the following:

  ...
  // If there are messages for the form, render them.
  if ($messages = theme('status_messages')) {
    $output = '
' . $messages . '
' . $output; }

Putting the $messages inside of a div with class "messages" causes problems for any theme that has a class for .messages because you always end up with <div class="messages"><div class="messages alert">...</div></div> In this case a class definition like padding:10px; will cause a doubling of that padding... Would you be open to changing that class to "messages_wrap" (or anything else?)

I'll happily submit the patch if you're amenable...

Comments

Dave Reid’s picture

Title: modal form ".messages" div causes theming problems » Remove extraneous div.messages from ctools_modal_form_render()
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Active » Needs review
FileSize
456 bytes
456 bytes

I tested this and it seems to be a good change actually. I'm not sure why we have the extra div? Regardless, here's a patch to remove the div wrapper for both 7.x-1.x and 6.x-1.x.

merlinofchaos’s picture

Status: Needs review » Fixed

Strange. I am sure that, at one point, that div had a purpose. No idea what it might've been, though.

Committed to D6 and D7.

bleen’s picture

sweet!! Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.