Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.While a consistent GUI and workwise is important for such a CMS as Drupal I would like to make this task a must have!
I was tend to set the 'priority' to critical because I think that consistency _is_ critical for a project like drupal.
Let's hope that we could make drupal look the same and make a more standardized workflow..
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | active-help-messages-consistency.patch | 54.28 KB | Stefan Nagtegaal |
| #2 | system-module-inconsistency.patch | 655 bytes | Stefan Nagtegaal |
| #1 | node-modules-inconsistency.patch | 6.89 KB | Stefan Nagtegaal |
Comments
Comment #1
Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commentedThe patch brings up a little more consistency in the node modules (blog, forum, and story.module). Ie:
- make the helptext under the 'Explanation or submission guidelines', more the same (blog & story);
- makes the form_set_error() consistent when the body of a blog/story does not match or exceeds the specified minimal numer of words.
- used the $options for form_select() and form_radios() inline like we do in the rest of drupal;
- Made the textarea sizes for the submission pages the same for all nodetypes and also for the 'Explanation or submission guidelines';
This patch exceeds this bug report/feature request
Comment #2
Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commentedFunction
system_settings_form()is used to return the submit buttons ('Save configuration' and 'Reset to defaults') on the '_settings' pages.If there is no $form present, we should not return the submit buttons.
(This is happening when the taxnomy.module is disabled and the forum.module is enabled. We get a nice error message at the forum settings page, but the submit buttons are also displayed, which shouldn't imo)
Comment #3
Dries CreditAttribution: Dries commentedCommitted the first patch. The second needs a bit more thought.
Comment #4
(not verified) CreditAttribution: commentedWhat is wrong with the second patch, Dries?
Comment #5
Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commentedPatch for making the
menu_get_active_help()-text consistent inside drupal. With this patch applied every helptext is put between<p>...</p>, like it should..Please review and apply!
Comment #6
Dries CreditAttribution: Dries commentedWhat do you guys think about this?
Comment #7
drummThese should probably be separate issues.
#2: is there an example of an empty form being passed to that function anywhere?
#5: +1
Comment #8
Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commentedIf there is no $form present, we should not return the submit buttons.
(This is happening when the taxnomy.module is disabled and the forum.module is enabled. We get a nice error message at the forum settings page, but the submit buttons are also displayed, which shouldn't imo)
Comment #9
moshe weitzman CreditAttribution: moshe weitzman commentedre: #5. I find it clutterring to add P tag around all help texts. The theme can add these tags, or maybe when we invoke the help hook.
a critical problem is one where your site does not work at all. this is non criticial.
Comment #10
Steven CreditAttribution: Steven commentedWe should indeed add <p> tags to all help text. This is because there are multi-paragraph help texts in drupal: they each contain multiple <p> tags. The single-paragraph helps don't at the moment. If the theme were to add <p> tags, then it could only do that for single-paragraph help texts, and this would require some logic.
So definitely +1 on requiring <p> tags everywhere.
Comment #11
killes@www.drop.org CreditAttribution: killes@www.drop.org commentedDoes not apply anymore. Smaller patches might be better ;)
Comment #12
Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commentedPatch was committed a long tiome ago...