Wrong date format for role expiration date [#1104142]

When adding/editing a role assignment feature, the absolute expiration date does not default to the correct date.

Drupal creates the select elements with the day/month values without a 0 prefix where as the uc_roles module uses the 0 prefix when setting a default value. Attached a patch to use the non-prefix formatting.

Comment	File	Size	Author
#4	1104142-uc_roles.patch	1.94 KB	mjpa
	uc_roles_expiration_date.patch	1.68 KB	mjpa

Comments

Comment #1

tr commented 31 March 2011 at 04:30

Status:

Active

» Needs review

You should set the status to "Needs review" when you supply a patch so others know there is a solution waiting to be reviewed.

Comment #2

31 March 2011 at 04:41

Status:

Needs review

» Needs work

The last submitted patch, uc_roles_expiration_date.patch, failed testing.

Comment #3

tr commented 31 March 2011 at 05:14

In this case the testbot is right - patch was rolled from the uc_roles directory rather than the ubercart directory.

Comment #4

mjpa commented 31 March 2011 at 18:31

Version:	6.x-2.4	» 6.x-2.x-dev
Status:	Needs work	» Needs review

Status	File	Size
new	1104142-uc_roles.patch	1.94 KB

Re-roled the patch against -dev using the git method.

Comment #5

tr commented 31 March 2011 at 18:38

Patch looks good. testbot will still probably fail, but this time that will be because the testbot is having problems rather than because of the patch.