Also affects 6.x-2.x. In 6.x-1.x it is called from apachesolr_cron.

CommentFileSizeAuthor
#11 1098860-11.patch481 bytesjpmckinney
#2 1098860-2.patch4.59 KBjpmckinney

Comments

jpmckinney’s picture

jpmckinney commented

Note theme_apachesolr_breadcrumb_tid is also never called (should probably be its own issue).

jpmckinney’s picture

jpmckinney commented
Status: Active » Needs review
StatusFileSize
new 1098860-2.patch4.59 KB

Remove code that is never called.

jpmckinney’s picture

jpmckinney commented
Category: bug » task
pwolanin’s picture

pwolanin commented
Category: task » bug

Well, this function is supposed to be called to verify that all the unpublished content is removed from the index.

jpmckinney’s picture

jpmckinney commented

I understand the point. I assume a well-functioning site would not have to call it. Maybe just put it in the handbook if people need it?

pwolanin’s picture

pwolanin commented

The question is more the functioning of the server - e.g. a delete that's sent may not happen if there is a server error.

jpmckinney’s picture

jpmckinney commented
Status: Needs review » Active

K, we can keep it in the module, but we should document somewhere that this function exists, because it is not called from anywhere in the module and so there is no way to discover it without reading the source.

jpmckinney’s picture

jpmckinney commented
Component: Code » Documentation
Category: bug » task
pwolanin’s picture

pwolanin commented

We should add it back to the cron hook - for some reason it must have been removed by Robert in 6.x-2.x

jpmckinney’s picture

jpmckinney commented
Component: Documentation » Code
jpmckinney’s picture

jpmckinney commented
Title: apachesolr_cron_check_node_table is never called » Add apachesolr_cron_check_node_table back to cron
Status: Active » Fixed
StatusFileSize
new 1098860-11.patch481 bytes

Committed to 7.x and 6.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.