Megamenu: parent link not active when visiting child page

I got this working on mine. What I did was add:

function menu_tree_full($menu_name = 'navigation') {
  $tree = array();
  if (!isset($menu_output[$menu_name])) {
    $tree = menu_find_active_trail(menu_tree_all_data($menu_name));
  }
  return $tree;
}

/**
 * Wrapper function
 */
function menu_find_active_trail(&$menu_tree) {
  $item = menu_get_item();
  _menu_find_active_trail($menu_tree, $item);
  return $menu_tree;
}
/**
 * Recursive function to find the active menu and the active trail in the given tree.
 */
function _menu_find_active_trail(&$menu_tree, $item) {
  foreach($menu_tree as &$menu_item) {
    $link = &$menu_item['link'];
    if ($link['href']==$item['href']) { // Found the exact location in the tree
      $link['active'] = TRUE;
      $link['in_active_trail'] = TRUE;
      return true;
    } else {
      if ($menu_item['below']) {
        $result = _menu_find_active_trail($menu_item['below'], $item);
        $link['in_active_trail'] = $result;
        if ($result) 
        {
          $link['active'] = TRUE;
          $link['in_active_trail'] = TRUE;
          return true;
        }
      }
    }
  }
  return false;
}

to template.php at the end. (adapted from here)

I then changed lines 102-105 from this:

  // primary links markup
  if (theme_get_setting('menu_type') == 2) { // use mega menu
    $vars['mainmenu'] = theme('mega_menu', array('menu' => menu_tree_all_data(theme_get_setting('menu_element'))));
  }

to this:

  // primary links markup
  if (theme_get_setting('menu_type') == 2) { // use mega menu
    $vars['mainmenu'] = theme('mega_menu', array('menu' => menu_tree_full(theme_get_setting('menu_element'))));
  }

and then in theme/theme.inc at about line 129 I added:

      if ($value['link']['in_active_trail']) {
        $options['attributes']['class'] = array('active');
      }

Core does this automatically. However, marinelli does a lot of overriding and bypasses the portion of core that populates the active trail. What the stuff I changed does is manually figure out the active trail.

You should be able to use sub-theming. Or, hopefully this will be considered helpful enough that it'll get committed.

Here's a patch file.

hi mcaden , thanks for the patch I'm testing it

Hmm...can't think of any scenario that wouldn't work with this, and I'm not familliar with Context.

hmm...try changing:
if ($link['href']==$item['href']) { // Found the exact location in the tree

to:

if ($link['href']==$item['href'] || $link['active']) { // Found the exact location in the tree

Hello, mcaden.

Thank you very much for your patch.

It seems to be working fine, except for one thing. After I have added your code to template.php, I get this error message:

Strict warning: Only variables should be passed by reference i menu_tree_full()

The error message then refers to line 286 in template.php. Below are code and line numbers after your code has been added:

283 - function menu_tree_full($menu_name = 'navigation') {
284 -   $tree = array();
285 -   if (!isset($menu_output[$menu_name])) {
286 -     $tree = menu_find_active_trail(menu_tree_all_data($menu_name));
287 -   }
288 -   return $tree;
289 - }

Do you have any ideas how to fix it? I would appreciate your help.

I tried the patch in #14, but it wasn't working for me. I have created both a main and secondary menu in my module (with a wildcard plus to_arg function for the secondary menu) and debugging it I found that in the function _menu_find_active_trail the variable $menu_item['below'] never got set. I have no clue why not, but I edited the patch to just look at the path to see if it is a parent or not. This is my fix of the function:

function _menu_find_active_trail(&$menu_tree, $item) {
  foreach ($menu_tree as &$menu_item) {
    $link = &$menu_item['link'];
    if ($link['href'] == $item['href']) { // Found the exact location in the tree
      $link['active'] = TRUE;
      $link['in_active_trail'] = TRUE;
      return true;
    } else {
//      if ($menu_item['below']) {
//        $result = _menu_find_active_trail($menu_item['below'], $item);
//        $link['in_active_trail'] = $result;
//        if ($result)
//        {
//          $link['active'] = TRUE;
//          $link['in_active_trail'] = TRUE;
//          return true;
//        }
//      }
      $findparent = strpos($item['href'], $link['href']);
      if ($findparent !== FALSE) {
        $link['active'] = TRUE;
        $link['in_active_trail'] = TRUE;
        return TRUE;
      }      
    }
  }
  return FALSE;
}

Now it works, so still many thanks for supplying the patch!

Well, it is kind of a quick hack. What it does is see if a menu item path is part of the selected menu item path. So if you have a secondary menu item with path mymodule/item1/itemb and a primary menu item with mymodule/item1, that primary menu item will be made active. This works for my setup, however, I guess this can go wrong in cases where the menu path system is more complex. I have never worked with Contexts, so can't help you with that.

Hi la7ema (#13) or Dane,

After applying the patch in #14, I am receiving the same error as la7ema noted in #13. Did either of you get it fixed?

Update:
I made it work by removing the reference tag in the parameter of the wrapper function.
Here is the updated wrapper function which worked for me:

/**
* Wrapper function
*/
function menu_find_active_trail($menu_tree) {
$item = menu_get_item();
_menu_find_active_trail($menu_tree, $item);
return $menu_tree;
}