Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
It would be useful in some contexts if transliteration_get were exposed as a text format input filter.
Comments
Comment #1
pillarsdotnet CreditAttribution: pillarsdotnet commentedThe following patch adds filter support to the 7.x-3.x branch.
Comment #2
pillarsdotnet CreditAttribution: pillarsdotnet commentedBump and title change. The 7.x version of HTML Mail can use this feature if it is available.
Comment #3
pillarsdotnet CreditAttribution: pillarsdotnet commentedAnother bump and slightly better filter settings form.
Comment #4
smk-ka CreditAttribution: smk-ka commentedThis looks like a nice addition, still need some time to test. Could you please change all function names to use transliteration_filter_*() instead of _filter_transliteration_*()?
Comment #5
smk-ka CreditAttribution: smk-ka commentedComment #6
pillarsdotnet CreditAttribution: pillarsdotnet commentedSure. Patches for D6 and D7 attached. I also have working code here..
Comment #7
pillarsdotnet CreditAttribution: pillarsdotnet commentedComment #8
pillarsdotnet CreditAttribution: pillarsdotnet commentedTrying again on that D7 patch; ignore previous.
As an aside, please note that the original function names were chosen to comply with Drupal guidelines. See filter_example.module.
Comment #9
pillarsdotnet CreditAttribution: pillarsdotnet commentedReconsidering; this really ought to be a sub-module so it shows up in the "Input filter" section of the module listing.
Comment #10
pillarsdotnet CreditAttribution: pillarsdotnet commentedBump and re-roll.
Comment #11
pillarsdotnet CreditAttribution: pillarsdotnet commentedSee #1126692: Filter transliteration should be a sub-module of Transliteration
Comment #12
pillarsdotnet CreditAttribution: pillarsdotnet commentedLooks like this isn't going anywhere.
Comment #13
pillarsdotnet CreditAttribution: pillarsdotnet commentedReopening and linking to #1277136: Blockers to a 7.x-3.0 release?
Comment #14
amateescu CreditAttribution: amateescu commentedDo we really need three README files?
References a different project.
Inconsistent naming for
filter_transliteration_tips
.Needs a blank line before @see.
Comment #15
pillarsdotnet CreditAttribution: pillarsdotnet commented(/me does the happydance!)
Umm.. Sorry about the three README's. That's my personal convention; I write the original in Markdown and generate both HTML and TXT from that.
Let me know which version you prefer and I'll remove the other two.
Will fix the rest shortly.
Comment #16
amateescu CreditAttribution: amateescu commentedThe Drupal standard is to include a README.txt, so let's go with that one :)
Comment #17
pillarsdotnet CreditAttribution: pillarsdotnet commentedOn further reflection, there really isn't any useful information in the
README.txt
that isn't also in the.info
file, so I just deleted it.Fixed the rest and re-rolled against 6.x-3.x and 7.x-3.x.
Comment #18
amateescu CreditAttribution: amateescu commentedLooks good to me now. I think those @see's are not really needed anyway because they're referencing a function in the same file (and it's a really small file :)). Anyway, don't re-roll just for this change, they can be easily handled at commit-time.
Comment #19
sunHm. There's a module namespace issue here.
Normally, this should be transliteration_filter, but of course, that leads to rather wonky function names like transliteration_filter_filter_info()...
Is there actually any reason for making this a separate sub-module?
Looks like these 50 lines could as well live in the .module?
Comment #20
sunCan be removed.
The description is the title.
Leave the description empty, if there's nothing to describe.
Uhm, this needs work. ;)
Can be removed.
The additional spaces before and after the field can be removed.
Why 5?
Should be removed.
I don't think that ordinary end-users are going to understand what this means.
Comment #21
pillarsdotnet CreditAttribution: pillarsdotnet commentedRe-rolled according to suggestions.
Comment #22
pillarsdotnet CreditAttribution: pillarsdotnet commentedComment #23
amateescu CreditAttribution: amateescu commented@pillarsdotnet, you forgot about this part:
Let's move the filter to transliteration.module :)
Comment #24
pillarsdotnet CreditAttribution: pillarsdotnet commentedThe reason for making this a separate sub-module is so that it shows up with the rest of the filter modules in the module listing.
Comment #25
amateescu CreditAttribution: amateescu commentedPasting @sun's comments from IRC:
Comment #26
pillarsdotnet CreditAttribution: pillarsdotnet commentedAnd if you think all of the below sound equally "wonky", then please suggest an alternate wording; I'm out of ideas:
Or better yet, close the issue as "won't fix" and I will continue to maintain the separate Filter transliteration module.
Comment #27
Freso CreditAttribution: Freso commentedI actually think "
" works fine, perhaps just some examples need embedding? (E.g., "Non-latin text (e.g., å, ö, 漢) ... US-ASCII equivalents (a, o, ?)." I don't think we should remove the technical terms just because they're technical. People can either use the examples to guide them or look up the terms they're unsure of.Whether the code is living in Transliteration or in your own module, the code (incl. wording) comments are just as valid.
Comment #28
amateescu CreditAttribution: amateescu commentedCleaned-up a bit the patches from #26 and committed to 6.x-3.x and 7.x-3.x. I decided to include this functionality in the main module though.
Thanks for all the work on this, Bob :)
http://drupalcode.org/project/transliteration.git/commit/ee9b55e
http://drupalcode.org/project/transliteration.git/commit/6a53653