If you click "Preview message" and then "Send message" you will send a empty message. The reason is that when you click on the preview is displayed correctly but the message body field is empty.

Thanks

CommentFileSizeAuthor
#5 fix_message_body_preview.patch1.89 KBberdir

Comments

Flo.’s picture

Flo. commented

I just wanted to state the fact that the 7.x-1.x-dev-Branch is not affected by this bug. Everything there works fine.

Bbi’s picture

Bbi commented

Flo I am using drupal 6. I can not use 7.x module version.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Postponed (maintainer needs more info)

Can you try to reproduce this on a clean install with just core and Privatemsg installed? Because I can't. And we have automated tests to verify that exactly this works.

I suspect it's a conflict with another contrib module, are you using wyswiwyg editors or something like that?

So, please..

- Try to reproduce with just Privatemsg installed as described above
- If you can't (I suspect that), try to figure out which module is responsible by temporarly disabling the one by one (or half of them and so on)
- Provide screenshots if you can reproduce (of your actual site, if possible).

Bbi’s picture

Bbi commented
Version: 6.x-1.x-dev » 6.x-2.x-dev
Status: Postponed (maintainer needs more info) » Active

Sorry Berdir I was using 6.x-2.x-dev. this version is gone and confused me, so I report the version 6.x-1. instead of 6.x-2.x-dev.

Anyway, I installed the 6.x-2.x-dev in a new drupal installation, and the error is reproduced. I uncheck "Show preview button on compose form" to avoid problems with my users.

Why version 6.x-2.x-dev has disappeared?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new fix_message_body_preview.patch1.89 KB

Oh, you are of course correct.

It *is* broken in 6.x-2.x and our test is crap because it doesn't verify this :)

Fixed the bug and improved the test, please test.

PS: We had to re-create the 6.x-2.x branch because something went wrong during the git migration and automated testing.

Bbi’s picture

Bbi commented

Thanks Berdir, its work fine. Very good job.
Will you include this patch in the new 6.x-2.x-dev?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Version: 6.x-2.x-dev » 7.x-1.x-dev
Status: Needs review » Patch (to be ported)

Yes. Commited.

The tests should be added to 7.x-1.x too...

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Patch (to be ported) » Fixed

Ported the tests to 7.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.