Just filing a Request to upgrade to drupal 5.x
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | liquid.tar_.gz_.txt | 34.92 KB | xequae |
| #6 | liquid.patch | 16.6 KB | xequae |
Just filing a Request to upgrade to drupal 5.x
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | liquid.tar_.gz_.txt | 34.92 KB | xequae |
| #6 | liquid.patch | 16.6 KB | xequae |
Comments
Comment #1
Charles Oertel CreditAttribution: Charles Oertel commentedHas anybody started on this? I am about to try to convert it to 5.0 but since I am quite new to Drupal and know little about liquid other than that I like to use it on my sites. If anybody has a work in progress I would appreciate it.
Comment #2
mfh CreditAttribution: mfh commentedindeed as most modules are incompatible between 4.6/4.7 and 5, this seems important.
I'm completely new to this project, I have the following questions
- is there a synoptic page about this project ?
- in the beginning, someone critizised the use of special nodes for a wiki,
one could agree : why not just add a "View" for wiki translation ?
- are there other wiki engines for drupal, is there a comparision ?
- is it easy to make the standard "page not found" having a link like "..do you want to create it ?" without installation of a module ? (of course, one would like to have the PATH info prefilled (and maybe also page title) prefilled with the inexisting page name) - in fact, given a wysiwyg editor, this would approximately fill my personal needs...
thanks
Comment #3
xequae CreditAttribution: xequae commentedI have it working with 5.0. It isn't finished, but I'll update it as soon as I do some more testing.
Comment #4
Christefano-oldaccount CreditAttribution: Christefano-oldaccount commentedsubscribing
Great news, xequae. Thanks.
Comment #5
xequae CreditAttribution: xequae commentedI have wiki filters and wiki page modules updated
In the liquid module, I have view, edit and delete working. Move and Wiki tabs still need a little work though. Hopefully I can have a patch in the next couple days.
Comment #6
xequae CreditAttribution: xequae commentedHere is a patch against 4.7.x-1.x-dev to get the liquid module to work with drupal 5.0. I've tested it and it seems to be working, but there may still be some issues with this code.
Comment #7
dismalhiker CreditAttribution: dismalhiker commentedFirst, thank you xequae for updating this module! I tried the patch and got the following (below). Any thoughts? Thanks. - jc
Comment #8
spooky69 CreditAttribution: spooky69 commentedCannot help, but watching with great interest
Comment #9
dismalhiker CreditAttribution: dismalhiker commentedThe problem noted in comment #7 (liquid_filters.module Hunk #1 FAILED at 61) when applying liquid.patch may not actually be a problem.
Upon closer inspection, it appears that there is no difference between the patch code for the liquid_filters.module and the original code in ver 4.7. In other words, the error results from there being no diff to apply.
So, I tested the patched liquid wiki module and it works fine. I haven't fully tested it, but the patch given in comment #6 does appear to work.
Comment #10
jasonwhat CreditAttribution: jasonwhat commentedCould you post the full 5.0 version of the module. That will help get more people testing since so many of us have patch-a-phobia.
Comment #11
xequae CreditAttribution: xequae commentedHey, that is great that it is working for you dismalhiker.
I can post a full version on Monday. I'm doing this work at work, so I can post it then.
Comment #12
anarcat CreditAttribution: anarcat commentedHi,
I just tested this patch on the current 4.7 branch and it applies cleanly. The patch also works pretty well for my tests. I am using it in replacement of the wiki.module (that has not been updated since 4.6) to parse my wiki content and it works pretty well (aside from the fact that the markup language is different).
So I'm marking this ready to be committed, sorry if I'm being bold. :)
Comment #13
lockey CreditAttribution: lockey commentedhi. is there a option for users to submit new pages or submit requests to edit a page and have admin approve them beofre being published?
Comment #14
xequae CreditAttribution: xequae commentedanarcat - Glad it worked for you and you think it is ready for commit.
lockey - It may be able to be used in conjunction with Drupal's built in moderation system, but I have never tried it.
Here is a full version of liquid wiki for 5.0 for those who are uneasy about using a patch. It wouldn't let me upload a .tar.gz file, so I added .txt on the end to get it to upload correctly. Just delete the .txt extension from the filename.
Comment #15
misterlu CreditAttribution: misterlu commentedI got a problem, i apply the patch and it work perfect.
But i got one problem. The link are not done :-(
I don't know where it's come.
i got my site like http://XXXXXXX/?q=wiki/index (for my index files)
And for the link when i create a [[sous part 1]] he make me a link like http//XXXXXXX/sous_part_1 and it say not found...
Any idea ?
Comment #16
drupal-is-OK CreditAttribution: drupal-is-OK commentedThanks a ton xequae. Grabbing something by the horns and just fixing it is why drupal is suck a great app. I'm doing a clean install and am looking forward to installing a clean wiki module using your txt file above.
Thanks again,
Drew
_____________________
www.wikidpad.com
Comment #17
matt_paz CreditAttribution: matt_paz commentedFirst. Thanks for all the work! Have you tried it w/ caching turned on? I haven't had a chance to test it yet, but remembered that I had to make a small mod to get it to work with caching turned on. Thanks again.
Comment #18
xequae CreditAttribution: xequae commentedmisterlu, I'm not sure what is going on. I have clean URL's turned on so maybe that is the issue. Is it possible to post your URL, so I can look at the message??
drupal-is-OK, Thanks!!
matt_paz, I don't have caching turned on, so I'm not sure. If you find out one way or another let me know.
I would like to get the development of this modules active again. It is really great and I would like to start adding some new features to it. Also I would like to get any issues with it resolved. I tried to contact the maintainer of the project, but couldn't find any contact information, so I could get this and future changes integrated into it. Anybody have any ideas on how to proceed to get these changes integrated into the main branch??
Comment #19
sorenp CreditAttribution: sorenp commentedI'm really sorry that I haven't been able to respond to this issue before now. Could have saved you guys a lot of trouble.
As I have previously indicated. A complete rewrite of liquid has been running for quite some time now, and that version has been targeted at Drupal 5.1.
I made the release some 40 minutes ago so it should be available for download now.
Comment #20
sorenp CreditAttribution: sorenp commented