This module would be really usable with a "Collapsible - Collapsed" option for the smileys select box (essential if you install a lot of smileys). Also, when smileys are presented to the user at the select box, this module shows all smileys based on text shortcuts, so you can see the same smiley repeated several times (for example, :-D and :D gives you the same smiley). This is an interface nonsense from the user view.

With these 2 improvements, this module would be the cleanest and most elegant smileys implementation of any forum system that I have seen!

Comments

Xabi’s picture

Xabi CreditAttribution: Xabi commented

I don't know if this is the correct coding method, but I have hardcoded the smileys.module to force a collapsed select box adding this line:

'#collapsed' => TRUE,

..after line 62.

Xabi’s picture

Xabi CreditAttribution: Xabi commented
Status:Active» Needs work

Changing line 32...

$result = db_query('SELECT * FROM {smileys} ' . $whereclause);

to...

$result = db_query('SELECT DISTINCT image FROM {smileys} ' . $whereclause);

...shows the smileys at the select box as they should be (every smiley is different from all others), but the acronyms don't appear when you click a smiley, only a blank space. Also, it seems that the function _smileys_list is shared by the select box and admin/compose tip views, so this is not the best approach (maybe a dedicated function for the select box would be nice). I don't know how to solve this, so I stop here.

Gurpartap Singh’s picture

Gurpartap Singh CreditAttribution: Gurpartap Singh commented
Status:Needs work» Fixed

Collapsible - Collapsed fieldset will be committed soon. And for distinct smileys for similar acronyms, it's recommended you separate each acronym by space for single related smiley. Like for "grin", acronyms field would be ":D :-D :d :-d" (instead of having same smiley repeated for each acronym). Hope this helps you.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status:Fixed» Closed (fixed)
catch’s picture

catch CreditAttribution: catch commented
Version:5.x-1.x-dev» 5.x-1.1
Status:Closed (fixed)» Active

Smiley box was expanded in 1.1 release.

'#collapsed' => TRUE,

as described above, collapses it again.

Gurpartap Singh’s picture

Gurpartap Singh CreditAttribution: Gurpartap Singh commented
Status:Active» Closed (won't fix)

This won't go into code. As, generally in a block, one would like to see what they have to consume from it. If anyone has lots of smileys and wants to collpase by default, they can try the code above. Moreover, in another issue someone's working on having favorite smileys to be promoted to select box, etc.

YAFA’s picture

YAFA CreditAttribution: YAFA commented
Title:Collapsed smiley select box and don't repeat same smiley graphics» Collapsed smiley select box
Status:Closed (won't fix)» Active

Well, in fact I want to have a collapsed Smileys-Selectbox and the code-insertion of '#collapsed' => TRUE, doesn't work. I don't know why, cause it's not different to forms of other modules with collapsed fieldsets. I quadchecked typos, deleted cache data and tried it on other machines. I don't get it collapsed.

Any suggestions?

Gtx,
Felix Lieb aka YAFA

YAFA’s picture

YAFA CreditAttribution: YAFA commented
Status:Active» Closed (fixed)

Erm...

Sometimes I am the dummest muddler I know. I altered the code of my Testing-Installation and tried it on another installation. Sorry, is working...

Gtx,
Felix Lieb aka YAFA