Closed (fixed)
Project:
Omega
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
9 Mar 2011 at 05:04 UTC
Updated:
25 Jul 2011 at 21:02 UTC
Hi, while validating the XHTML Starterkit base theme I am working from I've found duplicate code in the omega/starterkit_xhtml/templates/zone.tpl.php file.
Line 28
<div class="<?php print $classes; ?>" <?php print $attributes;?>>
This produces duplicate classes such as
<div class="clearfix container-12 zone-static zone-before zone branding-zone" class="clearfix container-12 zone-static zone-before zone branding-zone">
Removing either the print $classes, or the print attributes gets rid of the duplicate.
Comments
Comment #1
himerus commentedgood catch, I'll have a look soon! (been rough this week during DrupalCon so far)
Comment #2
killua99 commentedYep that happen to me at my site killua.me
Comment #3
killua99 commentedAny change for this issues ??
Comment #4
himerus commentedThis has been committed to the 7.x-2.x dev version.
The class="
print $classes;" is the part that was/needed to be removed. (allowing other attributes to be passed via $attributes.Will be tagged in next release (2.2)
Comment #5
WillHall commentedIs there ever a circumstance in which $attributes might be empty? wouldn't a check be in order?
<div <?php if(!$attributes) { ?>class="<?php print $classes; ?>"<?php } else { print $attributes; }?>>I imagine if attributes was empty - it would be intentional.
Comment #6
scor commentedfor the records, #4 was fixed in http://drupalcode.org/project/omega.git/commitdiff/bba1fc63d2663f99473e0...
Comment #7
bocaj commented