Hi, while validating the XHTML Starterkit base theme I am working from I've found duplicate code in the omega/starterkit_xhtml/templates/zone.tpl.php file.

Line 28

 <div class="<?php print $classes; ?>" <?php print $attributes;?>>

This produces duplicate classes such as

	  <div class="clearfix container-12 zone-static zone-before zone branding-zone" class="clearfix container-12 zone-static zone-before zone branding-zone"> 

Removing either the print $classes, or the print attributes gets rid of the duplicate.

Comments

himerus’s picture

good catch, I'll have a look soon! (been rough this week during DrupalCon so far)

killua99’s picture

Yep that happen to me at my site killua.me

killua99’s picture

Any change for this issues ??

himerus’s picture

Status: Active » Needs review

This has been committed to the 7.x-2.x dev version.
The class=" print $classes; " is the part that was/needed to be removed. (allowing other attributes to be passed via $attributes.

Will be tagged in next release (2.2)

WillHall’s picture

Is there ever a circumstance in which $attributes might be empty? wouldn't a check be in order?

<div <?php if(!$attributes) { ?>class="<?php print $classes; ?>"<?php } else { print $attributes; }?>>

I imagine if attributes was empty - it would be intentional.

scor’s picture

bocaj’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.