When saving the og/users/%/titles page, no message appears when saving the page. A message should appear so that the user knows it's been saved.

CommentFileSizeAuthor
#1 1080232-confirm-message.patch1.08 KBmradcliffe

Comments

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 1080232-confirm-message.patch1.08 KB

That's a good idea. I had a confirmation for self-changing titles, but not for an administrator.

capellic’s picture

capellic
he/him/his
Location Austin, Texas
commented
Status: Needs review » Needs work

I couldn't get the patch to apply. It failed because your working environment had the original and the new file in a/b directories?

diff --git a/og_titles.module b/og_titles.module
index 33f50f6..982c4fa 100644
--- a/og_titles.module
+++ b/og_titles.module

I manually applied the patch but had to make some changes. How is that that your code is working without if statement curly-brackets? I had to add those in order not to get a fatal error.

Otherwise, the message shows as intended.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented

You don't need to have curly braces if you have one statement directly underneath a control structure/function, but it's technically against code standards here.

I'm still trying to figure git out, and right now "git diff" is giving these kinds of patches. patch -p1 will always patch correctly given that git command. It looks like I should be using "git diff --no-prefix", and it's odd that is not the default where in svn and cvs it is. Ugh...

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs work » Fixed

Need to commit some of these so I can work on d7 version.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.