When I update Rotating Banner using Drush, jquery.cycle and jquery.easing get deleted. I have to manually upload them via ftp.
Why is that?
Also, why can't you distribute those files with the module? Or at least place them in sites/all/libraries?
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 1078988.4-rotating_banner-libraries.patch | 6.05 KB | mrfelton |
| #3 | 1078988.3-rotating_banner-libraries.patch | 7.31 KB | mrfelton |
| #2 | 1078988.1-rotating_banner-libraries.patch | 7.31 KB | mrfelton |
| #1 | 1353892.1-cloud_zom-libraries.patch | 2.93 KB | mrfelton |
Comments
Comment #1
mrfelton commentedAttached patch makes use of libraries api module, whilst also allowing the files to be placed in the includes directory as is now. Ultimately though, it would be better to address #770372: Use jQuery UI Instead of jQuery Cycle/Easing. I updated the readme, and provided some notes for how it can be used with drush make.
Comment #2
mrfelton commentedWrong patch!! Try this one.
Comment #3
mrfelton commentedSlightly revised. Was looking in the wrong place for the easing code.
Comment #4
mrfelton commentedOf course, like most people I had the patch from #1145092: Notice: Undefined index: #file in theme_media_thumbnail() (line 288 of .../sites/all/modules/media/includes/media.theme.inc) applied when I wrote this, since the module simply doesn't work without that patch (nudge nudge, can we get that one committed?!).
Attached is an updated version of this patch, with all of the other code from the other mentioned patch.
Comment #5
socialnicheguru commentedthis works
Comment #6
Patrick Nelson commentedCan this be committed? Without it, the module fails to follow accepted practice and, as noted by jerrac above causes problems when updated via Drush.
And as long as this is a patch, we essentially have the same problem when it comes to updating.