I was wondering how open you would be to Implementing hook_advagg_css_alter in your module & potentially reworking some of your code.
I created an issue on my module for this #1078048: Support the CSS Embedded Images module

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikeytown2’s picture

Quick thoughts:
In the data column of the advagg_files table; add a new item to the data array called "css_emimage". This will hold the filepath & checksum of the files embedded in the css file. This means that when one changes an image any css aggregates that contain that image file will be regenerated. I think that will take care of the updating an image issue. Looks like I need another hook in advagg inside the advagg_flush_caches function.

new hook called hook_advagg_files_table return TRUE if you wish to have the counter incremented.

jcarnett’s picture

I'm open to the idea. I haven't used advagg though, so I'm not sure what kind of effort it'll take at this point.

mikeytown2’s picture

Module has only been out for a week and a half so I wouldn't have expected you to have used it yet. I'll start working on the code and create a patch for CSS Embedded Images then. I've already added the hook to advagg.

mikeytown2’s picture

Thoughts:

Looks like I need to rework advagg more allowing for multiple files to be returned by hook_advagg_css_alter; And for consistency allow hook_advagg_js_alter to do the same. For performance reasons I'll have to work around your file_exists calls as well. I plan on implementing this so that this code path only uses advagg hooks; none of the preprocess_page hooks.

For each file I need to support the following:
Prefix & suffix - for the IE conditional statements
css_140306de263b875e517bd94be306961c.css - would have the prefix <!--[if gte IE 8]><!-->
css_140306de263b875e517bd94be306961c.emimage.css would have the suffix <!--<![endif]-->
css_140306de263b875e517bd94be306961c.mhtml.css would have a prefix and suffix <!--[if lt IE 8]>, <!--<![endif]-->
Naming convention that supports 404 generation & all htaccess rules. I'm thinking I'll change the MD5 value and in the database it will have a flag letting advagg know to if its a emimage or a mhtml and ditch the emimage or mhtml extension.

Thinking about the names more and I might want to implement splitting up the aggregate into 3 bundles (short, medium and long lifetimes), before tackling this. It's basically bundlecache without the gui. Sure you could generate a better bundle with human interaction but having it auto select is nice because I would never have to worry about it again. Why am I telling you this? Because implementing the bundle cache feature in advagg might make this job easier as I will have a one to many relationship built to handle things like this module.

Hmm what ever I do I need to keep both projects (this and bundlecache) in mind. I could go the easy way & re purpose your preprocess_page hook to write to the advagg_css dir but then 404 generation wouldn't work.

Integration looks like a tough problem to crack, but I'm always up for the challenge. What I'm saying is don't expect a patch by the weekend, this could take some time. Your input is greatly appreciated.

mikeytown2’s picture

ok figured out how this can work & created some new hooks to make it happen. I think css_emimage is easier then bundle cache so I'll start here. These will probably need to be adjusted once this has been built but in theory this should work as is.

hook_advagg_filenames_alter - passes along

  $filenames[] = array(
    'filetype' => $filetype,
    'files' => $files,
    'counter' => $counter,
    'bundle_md5' => $bundle_md5,
  );

For this module it would create 2 new arrays in the $filenames variable with a new md5 value; one for emimage, one for mhtml. Records all 3 in a css_emimage db table. From there our next hook hook_advagg_css_extra_alter passes along $filename, $bundle_md5, $prefix, $suffix. We would take the $bundle_md5 look it up and set the prefix and suffix depending on what type it is.

finally hook_advagg_css_alter is called where $data, $files, $bundle_md5 is passed along. we lookup $bundle_md5 and figure out what kind of data manipulations we need to do depending if its an emimage or mhtml css file. Here we would alter the advagg_files table and add in the image files included in this css file.

The css_emimage table will look something like this
bundle_md5 - MD5 of the bundle
type - containing values that mean: do nothing, root file, emimage file, mhtml file.

For cache flush calls there is hook_advagg_files_table. Here we would get the data object back (we set it in hook_advagg_css_alter); check the checksum of each one via advagg_checksum() and if any don't match we return TRUE. This will signal that we need to rebuild all bundles that contain this CSS file because an image referenced in that css file has changed.

How does this sound?

AntiNSA’s picture

I use advagg and want to use css embedded image please let me know when you get this issue worked out so I can use both at once.

mikeytown2’s picture

Status: Active » Needs review
FileSize
12 KB

I tried to make this patch as unobtrusive as possible. There could be some re-factoring of my code and your code to cut down on code duplication. I could use a cache table instead of a regular DB table. When going to advagg route; once the file has been generated no file_exists checks are done. Let me know what you think :)

mikeytown2’s picture

FileSize
13.04 KB

fix for the schema name in install file.

mikeytown2’s picture

FileSize
15.79 KB

fix for oddness of php overwriting an array

mikeytown2’s picture

Title: Add in support for advagg » CSS Embedded Images - Add in support for advagg's hooks
omega8cc’s picture

Status: Needs review » Needs work

I tested it with Aegir Hostmaster and with Managing News.

While in Hostmaster it looks it works (but sometimes creates hanging cache purge actions for redis), it fails with Managing News due to loops:

Mar 13 17:38:15 intimate drupal: http://mn.o4.intimate.aegir.cc|1300037895|advagg|81.190.180.174|http://mn.o4.intimate.aegir.cc/sites/mn.o4.intimate.aegir.cc/files/advagg_css/css_dae1b94c27e45ed6604494c2c7944be4_0.css?redirect_counter=6|http://mn.o4.intimate.aegir.cc/dashboard|1||This request could not generate correctly. Loop detected. Request data: sites/mn.o4.intimate.aegir.cc/files/advagg_css/css_dae1b94c27e45ed6604494c2c7944be4_0.css
Mar 13 17:38:15 intimate drupal: http://mn.o4.intimate.aegir.cc|1300037895|advagg|81.190.180.174|http://mn.o4.intimate.aegir.cc/sites/mn.o4.intimate.aegir.cc/files/advagg_css/css_23b0939ec1acd3a4248b5b10291ff534_3.css?redirect_counter=6|http://mn.o4.intimate.aegir.cc/dashboard|1||This request could not generate correctly. Loop detected. Request data: sites/mn.o4.intimate.aegir.cc/files/advagg_css/css_23b0939ec1acd3a4248b5b10291ff534_3.css
Mar 13 17:38:48 intimate drupal: http://mn.o4.intimate.aegir.cc|1300037928|advagg|81.190.180.174|http://mn.o4.intimate.aegir.cc/sites/mn.o4.intimate.aegir.cc/files/advagg_css/css_8b25331ae25d5297e3eeec29805a01b9_0.css?redirect_counter=6|http://mn.o4.intimate.aegir.cc/feeds|1||This request could not generate correctly. Loop detected. Request data: sites/mn.o4.intimate.aegir.cc/files/advagg_css/css_8b25331ae25d5297e3eeec29805a01b9_0.css

After disabling patched css_emimage, the advagg works perfectly.

I'm using correct configuration in Nginx for advagg compatibility, so I'm not sure if this is something wrong with the patch/integration or with my config.

omega8cc’s picture

BTW: the location in the Nginx config to support AdvAgg:

https://github.com/omega8cc/nginx-for-drupal/blob/master/aegir/conf/ngin...

The settings used while testing AdvAgg and patched CSS Embedded Images:

if (file_exists('./modules/o_contrib/advagg/advagg.module')) {
  unset($conf['preprocess_css']); // disable hardcoded css aggregation
  unset($conf['preprocess_js']);  // disable hardcoded js aggregation
  $conf['advagg_enabled'] = 1;
  $conf['advagg_async_generation'] = 1;
  $conf['advagg_gzip_compression'] = 1;
  $conf['advagg_checksum_mode'] = "md5";
  $conf['advagg_debug'] = 0;
  $conf['advagg_dir_htaccess'] = 0;
  $conf['advagg_rebuild_on_flush'] = 0;
}
omega8cc’s picture

Status: Needs work » Needs review

No, I was wrong. I can reproduce this issue on fresh MN with AdvAgg install, without CSS Embedded Images module. Sorry for confusion. I will report this in the AdvAgg queue.

mikeytown2’s picture

Status: Needs review » Needs work

@omega8cc
I did find a bug with this... standby for a patch to css_emimage and advagg.

mikeytown2’s picture

Status: Needs work » Needs review
FileSize
16.72 KB
11.98 KB

all in one patch is first.
commit level patching is last.

mikeytown2’s picture

FileSize
4.44 KB

This is what I committed to advagg

omega8cc’s picture

@mikeytown2

Thanks! I will test it asap and will report back.

mikeytown2’s picture

Status: Needs review » Needs work

forked this to make testing easier; once most of the bugs have been worked out I'll crate a patch back here.
http://drupal.org/sandbox/mikeytown2/1094988

mikeytown2’s picture

Status: Needs work » Needs review
FileSize
12.69 KB

latest patch from fork below

Wim Leers’s picture

Subscribing. Interesting work going on here :) FWIW, I'm open to changes to BundleCache. (It hasn't been worked on since kkaefer transfered ownership to me. I haven't had the time yet to do anything with it yet, unfortunately.)

mikeytown2’s picture

@Wim Leers
I'm going to end up taking the idea of bundles from BundleCache and create a sub module for advagg. Once thats done I'll give u git on the project. Bundles can be done with 1 extra table (could be a cache table), I'll be working on it this week. Too many aggregation modules fight with each other, thus the need for hooks. I'm up to 11 hooks in advagg; almost all of them being used currently. Hopefully I don't need any more but I don't know until I create the new feature.

mikeytown2’s picture

Status: Needs review » Needs work

changing this to use a cache table

mikeytown2’s picture

Status: Needs work » Needs review
FileSize
12.41 KB

latest patch from fork below

mikeytown2’s picture

latest patch from fork below. Encountered some issues with the bundler sub-module that needed to be fixed.

Snapshot download
http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/c6403f157c...

Wim Leers’s picture

I completely agree we need consolidation. That's why I made the CDN module's 2.0 feature set a superset of CDN 1.0 and Parallel.

I'm looking forward to reviewing your results! :)

mikeytown2’s picture

mikeytown2’s picture

mikeytown2’s picture

mikeytown2’s picture

jcarnett’s picture

@mikeytown2 Thanks a ton for all your work. I've been really busy lately, but I should have time to take a look at it in the next couple of days.

mikeytown2’s picture

mikeytown2’s picture

alexbk66-’s picture

subscribing

I wonder if 6.x-2.x-dev includes this patch, so instead of applying the patch, simply install 6.x-2.x-dev?

mikeytown2’s picture

@alexbk66-
dev still doesn't include this patch... if it works for you, please say so; so this patch can be marked as RTBC.

Latest snapshot and patch from fork
http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/a578d73eba...

alexbk66-’s picture

@mikeytown2,

I'm not an expert in Drupal, I'm just trying to improve performance of my site, it's slow :(

I have both modules installed and I'm willing to try the latest version, but I need to understand what to look for?

I am not even clear what is the issue here? Can you please explain a little bit.

mikeytown2’s picture

issue is that the CSS Embedded Images module needs a bunch of code added to it in order to work with advagg. Download the snapshot and overwrite the module's files.

alexbk66-’s picture

thanks @mikeytown2, I'm not THAT incompetent.
I mean what is the issue when I have these two modules together? How can I see the problem?
And how can I ensure that after installing this patch the problem is gone?
I mean - if I don't see any problem currently, why should I upgrade?

mikeytown2’s picture

Your CSS files do not come from advagg, they come from css_emimage thus you don't get any of the benefits of advagg; It's like advagg isn't even turned on for CSS. Look at where your CSS is located in your generated html, it's not coming from .../advagg_css/...

alexbk66-’s picture

Thank you for the explanation.

I checked in Google, I get:

There are 11 CSS files served from hobbyblob.com. They should be combined into as few files as possible.
http://hobbyblob.com/profiles/drupal_commons/themes/acquia_commons/css/grid16-fluid.css
http://hobbyblob.com/profiles/drupal_commons/themes/acquia_commons/css/local.css
http://hobbyblob.com/profiles/drupal_commons/themes/fusion_core/css/grid16-fluid.css
http://hobbyblob.com/sites/default/files/advagg_css/css_1d3a09bb8fd3ceca90bc9a89a369255e_0.css
http://hobbyblob.com/sites/default/files/advagg_css/css_3877ac427a2e6f36e5c534158d9dd18c_0.css
http://hobbyblob.com/sites/default/files/advagg_css/css_5ea23706b96a836973717bd1fe4caf52_1.css
http://hobbyblob.com/sites/default/files/advagg_css/css_a42585eb2f206e253f2bf4a54c43ca58_0.css
http://hobbyblob.com/sites/default/files/advagg_css/css_b3734c628b57ed9f65cb5c70e432761e_0.css
http://hobbyblob.com/sites/default/files/advagg_css/css_dad67de36bdd5e029abc12c77e7fada0_0.css
http://hobbyblob.com/sites/default/files/advagg_css/css_dfe27c10b35f33856439a7212dbb4958_1.css
http://hobbyblob.com/sites/default/files/advagg_css/css_ee5ef9591cc6bea7807385b5c0cf10d0_0.css

Now I'm confused, there are 3 files (big ones) which are not coming from advagg_css, and 8 files come from advagg_css. Should they all be in one file?

So you suggest to install the latest dev version?

mikeytown2’s picture

The AdvAgg bundler will take one big aggregate and split it into 4 (by default); CSS Embedded Images will then take one of these CSS files and split it into 3. Thus you end up with up to 12 Aggregated CSS files to download on the first page load. The advantage is the majority of those aggregates will still be useful throughout the rest of your site.

The top 3 files are CSS files that where not added to the aggregates via drupal_add_css ($preprocess = FALSE) most likely.

mikeytown2’s picture

@alexbk66-
Does this patch work as you expect it to?

alexbk66-’s picture

FileSize
153.07 KB

I'm afraid that the more modules I install to improve performance - the slower it becomes!
I have both Advanced CSS/JS Aggregation and CSS Embedded Images installed and the outcome is very sad, it takes 30 seconds to download 'aggregated' CSS files, see attached screenshot.

I refresh the same page, still get the same 'temporary redirect 307' for these files and these files get downloaded every time. The file sizes are 222B, but it takes more that a second each!

Also from the screenshot you can see that many png and jpg files are still downloaded directly. And if I create a new discussion - the page layout is screwed.

That's after installing the "Latest snapshot and patch from fork"
http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/a578d73eba...

It's either something really wrong with my configuration or these modules. Please help me!

alexbk66-’s picture

Additional info: I found errors in dblod related to the issue I mentioned above (creating a test discussion). Should I open an issue for advagg?

Type advagg
Location http://hobbyblob.com/sites/default/files/advagg_css/css_ff43587d46991598...
Referrer http://hobbyblob.com/discussion/test-discussion
Message This request could not generate correctly. Loop detected. Request data: sites/default/files/advagg_css/css_ff43587d4699159837485f1cc786bd40_0.css
Severity notice

mikeytown2’s picture

no need to create an issue in advagg; new patch that should take care of the issue.

Latest snapshot and patch from fork
http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/5b9bd76662...

alexbk66-’s picture

I installed http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/5b9bd76662...
The error is gone now, but how can I test if it works? Or you can actually check?

I still have problem creating a new discussion, but it's caused by advagg, cause it happens even if I disable css_emimage.

I'm afraid that these modules make my site slower, because apparently the problem is in limited hosting resources, not the file transfer. So by additional processing of CSS/JS I reduce the data transfer a bit, but significantly increase DB and CPU load.

That's a well known problem with Drupal, it works well only on VPS, not shared hosting. Very disappointing!

HobbyBlob.com

mikeytown2’s picture

Disable the CSS & JS Compression modules; that should speed things up server side.

mikeytown2’s picture

Status: Needs review » Needs work

patch out of sync with latest MHTML changes for IE.
#1147276: MHTML no longer works after Microsoft security update

mikeytown2’s picture

Status: Needs work » Needs review
FileSize
17.44 KB
philbar’s picture

Status: Needs review » Needs work

I'm getting a bunch of error messages:

    user warning: Table 'bioworld_main.cache_css_emimage_advagg' doesn't exist query: SELECT data, created, headers, expire, serialized FROM cache_css_emimage_advagg WHERE cid = 'd829e08d092518363d947157fb64015f' in /home/bioworld/public_html/includes/cache.inc on line 26.
    user warning: Table 'bioworld_main.cache_css_emimage_advagg' doesn't exist query: SELECT data, created, headers, expire, serialized FROM cache_css_emimage_advagg WHERE cid = 'd829e08d092518363d947157fb64015f' in /home/bioworld/public_html/includes/cache.inc on line 26.
    user warning: Table 'bioworld_main.cache_css_emimage_advagg' doesn't exist query: SELECT data, created, headers, expire, serialized FROM cache_css_emimage_advagg WHERE cid = 'd829e08d092518363d947157fb64015f' in /home/bioworld/public_html/includes/cache.inc on line 26.
    user warning: Table 'bioworld_main.cache_css_emimage_advagg' doesn't exist query: SELECT data, created, headers, expire, serialized FROM cache_css_emimage_advagg WHERE cid = 'd829e08d092518363d947157fb64015f' in /home/bioworld/public_html/includes/cache.inc on line 26.
    user warning: Table 'bioworld_main.cache_css_emimage_advagg' doesn't exist query: SELECT data, created, headers, expire, serialized FROM cache_css_emimage_advagg WHERE cid = 'd829e08d092518363d947157fb64015f' in /home/bioworld/public_html/includes/cache.inc on line 26.
    user warning: Table 'bioworld_main.cache_css_emimage_advagg' doesn't exist query: SELECT data, created, headers, expire, serialized FROM cache_css_emimage_advagg WHERE cid = 'd829e08d092518363d947157fb64015f' in /home/bioworld/public_html/includes/cache.inc on line 26.
    user warning: Table 'bioworld_main.cache_css_emimage_advagg' doesn't exist query: SELECT data, created, headers, expire, serialized FROM cache_css_emimage_advagg WHERE cid = 'd829e08d092518363d947157fb64015f' in /home/bioworld/public_html/includes/cache.inc on line 26.
    user warning: Table 'bioworld_main.cache_css_emimage_advagg' doesn't exist query: SELECT data, created, headers, expire, serialized FROM cache_css_emimage_advagg WHERE cid = 'd829e08d092518363d947157fb64015f' in /home/bioworld/public_html/includes/cache.inc on line 26.
    user warning: Table 'bioworld_main.cache_css_emimage_advagg' doesn't exist query: SELECT data, created, headers, expire, serialized FROM cache_css_emimage_advagg WHERE cid = 'd829e08d092518363d947157fb64015f' in /home/bioworld/public_html/includes/cache.inc on line 26.
    user warning: Table 'bioworld_main.cache_css_emimage_advagg' doesn't exist query: SELECT data, created, headers, expire, serialized FROM cache_css_emimage_advagg WHERE cid = 'd829e08d092518363d947157fb64015f' in /home/bioworld/public_html/includes/cache.inc on line 26.
    user warning: Table 'bioworld_main.cache_css_emimage_advagg' doesn't exist query: SELECT data, created, headers, expire, serialized FROM cache_css_emimage_advagg WHERE cid = 'd829e08d092518363d947157fb64015f' in /home/bioworld/public_html/includes/cache.inc on line 26.
    user warning: Table 'bioworld_main.cache_css_emimage_advagg' doesn't exist query: SELECT data, created, headers, expire, serialized FROM cache_css_emimage_advagg WHERE cid = 'd829e08d092518363d947157fb64015f' in /home/bioworld/public_html/includes/cache.inc on line 26.
philbar’s picture

I uninstalled CSS Embedded Image, cleared my cache, then re-enabled the module and it appears to be working now.

Probably should include some way of doing this automatically.

philbar’s picture

Also, my images don't seem to be passing through CSS Embedded Images. I have it running on the following site and still get a message from Google Page Speed:

http://pagespeed.googlelabs.com/#url=http_3A_2F_2Fwww.bioworldusa.com_2F...

I cleared all my cache multiple times trying to get it to work.

alexbk66-’s picture

Same problem here

http://pagespeed.googlelabs.com/#url=http_3A_2F_2Fhobbyblob.com_2F&mobil...

But apart from this issue I'm surprised to 91 (out of 100) :)

mikeytown2’s picture

Status: Needs work » Needs review

@philbar
You need to run update.php first to add in the various tables.
Looking at your site I don't see CSS Embedded Images working correctly.

@alexbk66-
Looking at the first image file, it is located in the HTML DOM

Post date<img src="/misc/arrow-asc.png" alt="sort icon" title="sort ascending" width="13" height="13" /></a>

CSS Embedded Images is working correctly for you.

mikeytown2’s picture

so I didn't include a hook_update_N function in the patch, sorry about that.

Latest snapshot and patch from fork
http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/d776ec3fda...

alexbk66-’s picture

Yeah, it works, thank you!

But I didn't get your comment about "HTML DOM", can you please explain?

mikeytown2’s picture

http://pagespeed.googlelabs.com/#url=http_3A_2F_2Fhobbyblob.com_2F&mobil...

The following images served from hobbyblob.com should be combined into as few images as possible using CSS sprites.

http://hobbyblob.com/misc/arrow-asc.png
...
...

This image is in the HTML it is not in the CSS; thus the CSS Embedded Images module won't help you.

alexbk66-’s picture

Ah, thank you, I'll check the code

Duplika’s picture

Do we need to:

This processing is only done when Drupal's CSS optimization feature is enabled under Administer > Site configuration > Performance.

as stated at the CSS Embedded module?

Because if we do, Adv Agg complains at the status report page.

mikeytown2’s picture

You don't need to turn on Drupal's CSS optimization feature in order for CSS Embedded Images to work with this patch applied. AdvAgg is a completely different Aggregation approach compared to Drupal core. If you do enable core's CSS optimization; it is wasted cycles, we never use it's output. In short ignore the readme, I haven't patched that yet so say otherwise.

mikeytown2’s picture

Status: Needs review » Needs work

Report from #1164502: Notice: Undefined index: data in css_emimage_advagg_files_table() (line 298 of css_emimage.module) PHP E' Notice

  // Load the CSS file.
  $images = array();
  $css = advagg_build_css_bundle(array($row['filename']));
-  $data = unserialize($row['data']);
+  if (!empty($row['data'])) {
+    $data = unserialize($row['data']);
+  }

  // See if CSS file contains an image.
......
......
    else {
      $save = TRUE;
    }

-    if (!is_array($data['css_emimage'])) {
+    if (!empty($data['css_emimage']) && !is_array($data['css_emimage'])) {
      unset($data['css_emimage']);
    }
    $data['css_emimage'][$filename] = $checksum;
  }

  if ($save) {
    advagg_set_file_data($row['filename_md5'], $data);
mikeytown2’s picture

Status: Needs work » Needs review
FileSize
19.13 KB

Above issue is fixed in this latest patch.

Latest snapshot and patch from fork
http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/31840ba007...

Peter Bowey’s picture

#61 is working for me -> advagg + css_emimage
Thanks Mike!

philbar’s picture

#61 still doesn't work for me.

I completely uninstalled css_emimage and then installed your fork. I also performed a "master reset" on AdvAgg cache.

All my files are still normal images.

aze2010’s picture

Hey Folks,

cann anybody help me out?
I still got the Problems after #61.

Problem(message): "Adv CSS/JS Agg - Theme Hook Theme hook is not in the correct place."
I do have patched an got the latest dev's from both Moduels (CSS_Emimage and Agg).

What can i do to fix this problem?

Debug-info:

_rules_action_drupal_goto_handler
template_preprocess
template_preprocess_page
mobile_tools_preprocess_page
page_title_preprocess_page
nodewords_preprocess_page
css_emimage_preprocess_page
fusion_core_preprocess_page
content_profile_template_preprocess
ctools_preprocess_page
advagg_processor
conditional_styles_preprocess_page
cdn_preprocess_page
jquery_update_preprocess_page

i woul be much appreciated.

Many regards :-)

Peter Bowey’s picture

@aze2010
@philbar
Have you got the latest "css_emimage-advagg" snapshot patch from fork?
Location ->
http://drupalcode.org/sandbox/mikeytown2/1094988.git/shortlog/refs/heads...

or use: "git clone http://git.drupal.org/sandbox/mikeytown2/1094988.git fork_of_css_embedded_images" -- without the quotes

aze2010’s picture

yes, i do. My Drupal-Version is 6.22. What can i do else?

Thanks four your support!!!

Should i apply the patch from #61 to it?
I get a warning message that this Snapshot already has a patch applied :(.

mikeytown2’s picture

@aze2010
Are you using the latest version of advagg?
Try flushing your caches, in advagg_theme_registry_alter I remove jquery_update_preprocess_page from the list; which is whats causing the status page to throw that warning.

aze2010’s picture

@mikeytown2: YOU GOT IT! That was it! Thanky a lot.

I deactivate the Module "Jquery update".

Many many regards :-)

mikeytown2’s picture

well, you shouldn't have to disable jquery update. All you need to do is flush your caches.

mikeytown2’s picture

Status: Needs review » Needs work

Changing status due to #63; looks like I missed something.

alexbk66-’s picture

FileSize
5.52 KB

Mike, I'm afraid it's not working for me at all now. I redesign my site, so I installed 6.x-2.2 (no any patches applied), cleared caches (in phpMyAdmin to be sure).

I didn't enable advagg yet. Still all images are normal files. I even tried disabling jquery update :)

I was playing with .htaccess, not sure if it could cause issues, just in case attached.

Can you please advise.

alexbk66-’s picture

I installed the patch http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/31840ba007..., ran update.php, but still the same.

mikeytown2’s picture

Status: Needs work » Needs review
FileSize
19.07 KB

Above issue is fixed in this latest patch.

Latest snapshot and patch from fork
http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/f564ab3be2...

alexbk66-’s picture

Thank Mike, you are a gentleman!

philbar’s picture

Status: Needs review » Reviewed & tested by the community

#73 - Works for me!

mikeytown2’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
19.67 KB

Fixed an issue with a potential race condition. #1197280: race condition

Latest snapshot and patch from fork
http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/e65b10d4f6...

mikeytown2’s picture

Status: Needs review » Needs work

found a bug with bundles not getting incremented

mikeytown2’s picture

Status: Needs work » Needs review

site in question was using older code. putting this back to needs review

mikeytown2’s picture

Status: Needs review » Reviewed & tested by the community
Vacilando’s picture

Also expecting this patch to be applied to the module...

mikeytown2’s picture

fixed a php Warning in this latest patch. View the patch level diff.

Latest snapshot and patch from fork
http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/363fd8d6e8...

vasrush’s picture

#81 works great for me.

Mickey
thanks for your efforts.

omega8cc’s picture

We are using this forked version for months on many sites and it works great.
Please accept this tested patch.

jvieille’s picture

Using the fork successfully too - waiting for the updated module
Thanks

mikeytown2’s picture

jvieille’s picture

mikeytown2 please clarify
Was this patch committed at the same time than
http://drupal.org/node/1282154#comment-5416316 ?

In other words, would the last dev support for advagg's hooks?

Update: looking at the main page, the last dev is still one year old.
Can we have all this committed?
Thanks

mikeytown2’s picture

I have git access now, this will hopefully be committed sooner rather than later.

jvieille’s picture

Any hope this will be committed soon?

Thanks

jvieille’s picture

Category: support » task

Reminder
Thanks

hachreak’s picture

+1

I'd like to use this module with advagg! :)

jvieille’s picture

the maintainer did not participate in this flourishing post since the April 2011.
Do we have to give up using this module?

Is this module abandoned?

Peter Bowey’s picture

Very likely!

History shows this:
----------------------------------------------
Maintainers for CSS Embedded Images

jcarnett - 50 commits
last: 1 year ago, first: 2 years ago

All issues
17 open, 44 total
Bug reports
11 open, 23 total
----------------------------------------------
Ideal time for a new maintainer for http://drupal.org/project/css_emimage

But I suspect it will be abandoned.

The last found post by the current maintainer is:
http://drupal.org/node/1091704#comment-6325850

mikeytown2’s picture

Status: Reviewed & tested by the community » Fixed
omega8cc’s picture

Finally! Thank you!

hachreak’s picture

Thank you!
When we can download the new release? :D

jvieille’s picture

Its is committed, the last dev works for me.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

SocialNicheGuru’s picture

is this patch needed if you are using Drupal 7? On my status page it says it should be applied and brings me to this issue.