Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
I was wondering how open you would be to Implementing hook_advagg_css_alter in your module & potentially reworking some of your code.
I created an issue on my module for this #1078048: Support the CSS Embedded Images module
Comment | File | Size | Author |
---|---|---|---|
#85 | css_emimage-advagg-1078060-85.patch | 19.63 KB | mikeytown2 |
#81 | css_emimage-advagg-1078060-81.patch | 19.59 KB | mikeytown2 |
#76 | css_emimage-advagg-1078060-76.patch | 19.67 KB | mikeytown2 |
#73 | css_emimage-advagg-1078060-73.patch | 19.07 KB | mikeytown2 |
#71 | htaccess.txt | 5.52 KB | alexbk66- |
Comments
Comment #1
mikeytown2 CreditAttribution: mikeytown2 commentedQuick thoughts:
In the data column of the advagg_files table; add a new item to the data array called "css_emimage". This will hold the filepath & checksum of the files embedded in the css file. This means that when one changes an image any css aggregates that contain that image file will be regenerated. I think that will take care of the updating an image issue. Looks like I need another hook in advagg inside the advagg_flush_caches function.
new hook called hook_advagg_files_table return TRUE if you wish to have the counter incremented.
Comment #2
jcarnett CreditAttribution: jcarnett commentedI'm open to the idea. I haven't used advagg though, so I'm not sure what kind of effort it'll take at this point.
Comment #3
mikeytown2 CreditAttribution: mikeytown2 commentedModule has only been out for a week and a half so I wouldn't have expected you to have used it yet. I'll start working on the code and create a patch for CSS Embedded Images then. I've already added the hook to advagg.
Comment #4
mikeytown2 CreditAttribution: mikeytown2 commentedThoughts:
Looks like I need to rework advagg more allowing for multiple files to be returned by hook_advagg_css_alter; And for consistency allow hook_advagg_js_alter to do the same. For performance reasons I'll have to work around your file_exists calls as well. I plan on implementing this so that this code path only uses advagg hooks; none of the preprocess_page hooks.
For each file I need to support the following:
Prefix & suffix - for the IE conditional statements
css_140306de263b875e517bd94be306961c.css - would have the prefix
<!--[if gte IE 8]><!-->
css_140306de263b875e517bd94be306961c.emimage.css would have the suffix
<!--<![endif]-->
css_140306de263b875e517bd94be306961c.mhtml.css would have a prefix and suffix
<!--[if lt IE 8]>
,<!--<![endif]-->
Naming convention that supports 404 generation & all htaccess rules. I'm thinking I'll change the MD5 value and in the database it will have a flag letting advagg know to if its a emimage or a mhtml and ditch the emimage or mhtml extension.
Thinking about the names more and I might want to implement splitting up the aggregate into 3 bundles (short, medium and long lifetimes), before tackling this. It's basically bundlecache without the gui. Sure you could generate a better bundle with human interaction but having it auto select is nice because I would never have to worry about it again. Why am I telling you this? Because implementing the bundle cache feature in advagg might make this job easier as I will have a one to many relationship built to handle things like this module.
Hmm what ever I do I need to keep both projects (this and bundlecache) in mind. I could go the easy way & re purpose your preprocess_page hook to write to the advagg_css dir but then 404 generation wouldn't work.
Integration looks like a tough problem to crack, but I'm always up for the challenge. What I'm saying is don't expect a patch by the weekend, this could take some time. Your input is greatly appreciated.
Comment #5
mikeytown2 CreditAttribution: mikeytown2 commentedok figured out how this can work & created some new hooks to make it happen. I think css_emimage is easier then bundle cache so I'll start here. These will probably need to be adjusted once this has been built but in theory this should work as is.
hook_advagg_filenames_alter - passes along
For this module it would create 2 new arrays in the
$filenames
variable with a new md5 value; one for emimage, one for mhtml. Records all 3 in a css_emimage db table. From there our next hook hook_advagg_css_extra_alter passes along$filename, $bundle_md5, $prefix, $suffix
. We would take the $bundle_md5 look it up and set the prefix and suffix depending on what type it is.finally hook_advagg_css_alter is called where
$data, $files, $bundle_md5
is passed along. we lookup $bundle_md5 and figure out what kind of data manipulations we need to do depending if its an emimage or mhtml css file. Here we would alter the advagg_files table and add in the image files included in this css file.The css_emimage table will look something like this
bundle_md5 - MD5 of the bundle
type - containing values that mean: do nothing, root file, emimage file, mhtml file.
For cache flush calls there is hook_advagg_files_table. Here we would get the data object back (we set it in hook_advagg_css_alter); check the checksum of each one via advagg_checksum() and if any don't match we return TRUE. This will signal that we need to rebuild all bundles that contain this CSS file because an image referenced in that css file has changed.
How does this sound?
Comment #6
AntiNSA CreditAttribution: AntiNSA commentedI use advagg and want to use css embedded image please let me know when you get this issue worked out so I can use both at once.
Comment #7
mikeytown2 CreditAttribution: mikeytown2 commentedI tried to make this patch as unobtrusive as possible. There could be some re-factoring of my code and your code to cut down on code duplication. I could use a cache table instead of a regular DB table. When going to advagg route; once the file has been generated no file_exists checks are done. Let me know what you think :)
Comment #8
mikeytown2 CreditAttribution: mikeytown2 commentedfix for the schema name in install file.
Comment #9
mikeytown2 CreditAttribution: mikeytown2 commentedfix for oddness of php overwriting an array
Comment #10
mikeytown2 CreditAttribution: mikeytown2 commentedComment #11
omega8cc CreditAttribution: omega8cc commentedI tested it with Aegir Hostmaster and with Managing News.
While in Hostmaster it looks it works (but sometimes creates hanging cache purge actions for redis), it fails with Managing News due to loops:
After disabling patched css_emimage, the advagg works perfectly.
I'm using correct configuration in Nginx for advagg compatibility, so I'm not sure if this is something wrong with the patch/integration or with my config.
Comment #12
omega8cc CreditAttribution: omega8cc commentedBTW: the location in the Nginx config to support AdvAgg:
https://github.com/omega8cc/nginx-for-drupal/blob/master/aegir/conf/ngin...
The settings used while testing AdvAgg and patched CSS Embedded Images:
Comment #13
omega8cc CreditAttribution: omega8cc commentedNo, I was wrong. I can reproduce this issue on fresh MN with AdvAgg install, without CSS Embedded Images module. Sorry for confusion. I will report this in the AdvAgg queue.
Comment #14
mikeytown2 CreditAttribution: mikeytown2 commented@omega8cc
I did find a bug with this... standby for a patch to css_emimage and advagg.
Comment #15
mikeytown2 CreditAttribution: mikeytown2 commentedall in one patch is first.
commit level patching is last.
Comment #16
mikeytown2 CreditAttribution: mikeytown2 commentedThis is what I committed to advagg
Comment #17
omega8cc CreditAttribution: omega8cc commented@mikeytown2
Thanks! I will test it asap and will report back.
Comment #18
mikeytown2 CreditAttribution: mikeytown2 commentedforked this to make testing easier; once most of the bugs have been worked out I'll crate a patch back here.
http://drupal.org/sandbox/mikeytown2/1094988
Comment #19
mikeytown2 CreditAttribution: mikeytown2 commentedlatest patch from fork below
Comment #20
Wim LeersSubscribing. Interesting work going on here :) FWIW, I'm open to changes to BundleCache. (It hasn't been worked on since kkaefer transfered ownership to me. I haven't had the time yet to do anything with it yet, unfortunately.)
Comment #21
mikeytown2 CreditAttribution: mikeytown2 commented@Wim Leers
I'm going to end up taking the idea of bundles from BundleCache and create a sub module for advagg. Once thats done I'll give u git on the project. Bundles can be done with 1 extra table (could be a cache table), I'll be working on it this week. Too many aggregation modules fight with each other, thus the need for hooks. I'm up to 11 hooks in advagg; almost all of them being used currently. Hopefully I don't need any more but I don't know until I create the new feature.
Comment #22
mikeytown2 CreditAttribution: mikeytown2 commentedchanging this to use a cache table
Comment #23
mikeytown2 CreditAttribution: mikeytown2 commentedlatest patch from fork below
Comment #24
mikeytown2 CreditAttribution: mikeytown2 commentedlatest patch from fork below. Encountered some issues with the bundler sub-module that needed to be fixed.
Snapshot download
http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/c6403f157c...
Comment #25
Wim LeersI completely agree we need consolidation. That's why I made the CDN module's 2.0 feature set a superset of CDN 1.0 and Parallel.
I'm looking forward to reviewing your results! :)
Comment #26
mikeytown2 CreditAttribution: mikeytown2 commentedLatest snapshot and patch
http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/6733555daf...
Comment #27
mikeytown2 CreditAttribution: mikeytown2 commentedLatest snapshot and patch
http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/5fc1434ed1...
Comment #28
mikeytown2 CreditAttribution: mikeytown2 commentedComment #29
mikeytown2 CreditAttribution: mikeytown2 commentedLatest snapshot and patch from fork
http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/6867f65740...
Comment #30
jcarnett CreditAttribution: jcarnett commented@mikeytown2 Thanks a ton for all your work. I've been really busy lately, but I should have time to take a look at it in the next couple of days.
Comment #31
mikeytown2 CreditAttribution: mikeytown2 commentedLatest snapshot and patch from fork
http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/bbd4535c99...
Comment #32
mikeytown2 CreditAttribution: mikeytown2 commentedLatest snapshot and patch from fork
http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/8e5cae95c6...
Comment #33
alexbk66- CreditAttribution: alexbk66- commentedsubscribing
I wonder if 6.x-2.x-dev includes this patch, so instead of applying the patch, simply install 6.x-2.x-dev?
Comment #34
mikeytown2 CreditAttribution: mikeytown2 commented@alexbk66-
dev still doesn't include this patch... if it works for you, please say so; so this patch can be marked as RTBC.
Latest snapshot and patch from fork
http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/a578d73eba...
Comment #35
alexbk66- CreditAttribution: alexbk66- commented@mikeytown2,
I'm not an expert in Drupal, I'm just trying to improve performance of my site, it's slow :(
I have both modules installed and I'm willing to try the latest version, but I need to understand what to look for?
I am not even clear what is the issue here? Can you please explain a little bit.
Comment #36
mikeytown2 CreditAttribution: mikeytown2 commentedissue is that the CSS Embedded Images module needs a bunch of code added to it in order to work with advagg. Download the snapshot and overwrite the module's files.
Comment #37
alexbk66- CreditAttribution: alexbk66- commentedthanks @mikeytown2, I'm not THAT incompetent.
I mean what is the issue when I have these two modules together? How can I see the problem?
And how can I ensure that after installing this patch the problem is gone?
I mean - if I don't see any problem currently, why should I upgrade?
Comment #38
mikeytown2 CreditAttribution: mikeytown2 commentedYour CSS files do not come from advagg, they come from css_emimage thus you don't get any of the benefits of advagg; It's like advagg isn't even turned on for CSS. Look at where your CSS is located in your generated html, it's not coming from .../advagg_css/...
Comment #39
alexbk66- CreditAttribution: alexbk66- commentedThank you for the explanation.
I checked in Google, I get:
Now I'm confused, there are 3 files (big ones) which are not coming from advagg_css, and 8 files come from advagg_css. Should they all be in one file?
So you suggest to install the latest dev version?
Comment #40
mikeytown2 CreditAttribution: mikeytown2 commentedThe AdvAgg bundler will take one big aggregate and split it into 4 (by default); CSS Embedded Images will then take one of these CSS files and split it into 3. Thus you end up with up to 12 Aggregated CSS files to download on the first page load. The advantage is the majority of those aggregates will still be useful throughout the rest of your site.
The top 3 files are CSS files that where not added to the aggregates via drupal_add_css ($preprocess = FALSE) most likely.
Comment #41
mikeytown2 CreditAttribution: mikeytown2 commented@alexbk66-
Does this patch work as you expect it to?
Comment #42
alexbk66- CreditAttribution: alexbk66- commentedI'm afraid that the more modules I install to improve performance - the slower it becomes!
I have both Advanced CSS/JS Aggregation and CSS Embedded Images installed and the outcome is very sad, it takes 30 seconds to download 'aggregated' CSS files, see attached screenshot.
I refresh the same page, still get the same 'temporary redirect 307' for these files and these files get downloaded every time. The file sizes are 222B, but it takes more that a second each!
Also from the screenshot you can see that many png and jpg files are still downloaded directly. And if I create a new discussion - the page layout is screwed.
That's after installing the "Latest snapshot and patch from fork"
http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/a578d73eba...
It's either something really wrong with my configuration or these modules. Please help me!
Comment #43
alexbk66- CreditAttribution: alexbk66- commentedAdditional info: I found errors in dblod related to the issue I mentioned above (creating a test discussion). Should I open an issue for advagg?
Type advagg
Location http://hobbyblob.com/sites/default/files/advagg_css/css_ff43587d46991598...
Referrer http://hobbyblob.com/discussion/test-discussion
Message This request could not generate correctly. Loop detected. Request data: sites/default/files/advagg_css/css_ff43587d4699159837485f1cc786bd40_0.css
Severity notice
Comment #44
mikeytown2 CreditAttribution: mikeytown2 commentedno need to create an issue in advagg; new patch that should take care of the issue.
Latest snapshot and patch from fork
http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/5b9bd76662...
Comment #45
alexbk66- CreditAttribution: alexbk66- commentedI installed http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/5b9bd76662...
The error is gone now, but how can I test if it works? Or you can actually check?
I still have problem creating a new discussion, but it's caused by advagg, cause it happens even if I disable css_emimage.
I'm afraid that these modules make my site slower, because apparently the problem is in limited hosting resources, not the file transfer. So by additional processing of CSS/JS I reduce the data transfer a bit, but significantly increase DB and CPU load.
That's a well known problem with Drupal, it works well only on VPS, not shared hosting. Very disappointing!
HobbyBlob.com
Comment #46
mikeytown2 CreditAttribution: mikeytown2 commentedDisable the CSS & JS Compression modules; that should speed things up server side.
Comment #47
mikeytown2 CreditAttribution: mikeytown2 commentedpatch out of sync with latest MHTML changes for IE.
#1147276: MHTML no longer works after Microsoft security update
Comment #48
mikeytown2 CreditAttribution: mikeytown2 commentedLatest snapshot and patch from fork
http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/51a01229bb...
Comment #49
philbar CreditAttribution: philbar commentedI'm getting a bunch of error messages:
Comment #50
philbar CreditAttribution: philbar commentedI uninstalled CSS Embedded Image, cleared my cache, then re-enabled the module and it appears to be working now.
Probably should include some way of doing this automatically.
Comment #51
philbar CreditAttribution: philbar commentedAlso, my images don't seem to be passing through CSS Embedded Images. I have it running on the following site and still get a message from Google Page Speed:
http://pagespeed.googlelabs.com/#url=http_3A_2F_2Fwww.bioworldusa.com_2F...
I cleared all my cache multiple times trying to get it to work.
Comment #52
alexbk66- CreditAttribution: alexbk66- commentedSame problem here
http://pagespeed.googlelabs.com/#url=http_3A_2F_2Fhobbyblob.com_2F&mobil...
But apart from this issue I'm surprised to 91 (out of 100) :)
Comment #53
mikeytown2 CreditAttribution: mikeytown2 commented@philbar
You need to run update.php first to add in the various tables.
Looking at your site I don't see CSS Embedded Images working correctly.
@alexbk66-
Looking at the first image file, it is located in the HTML DOM
CSS Embedded Images is working correctly for you.
Comment #54
mikeytown2 CreditAttribution: mikeytown2 commentedso I didn't include a hook_update_N function in the patch, sorry about that.
Latest snapshot and patch from fork
http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/d776ec3fda...
Comment #55
alexbk66- CreditAttribution: alexbk66- commentedYeah, it works, thank you!
But I didn't get your comment about "HTML DOM", can you please explain?
Comment #56
mikeytown2 CreditAttribution: mikeytown2 commentedhttp://pagespeed.googlelabs.com/#url=http_3A_2F_2Fhobbyblob.com_2F&mobil...
The following images served from hobbyblob.com should be combined into as few images as possible using CSS sprites.
http://hobbyblob.com/misc/arrow-asc.png
...
...
This image is in the HTML it is not in the CSS; thus the CSS Embedded Images module won't help you.
Comment #57
alexbk66- CreditAttribution: alexbk66- commentedAh, thank you, I'll check the code
Comment #58
Duplika CreditAttribution: Duplika commentedDo we need to:
as stated at the CSS Embedded module?
Because if we do, Adv Agg complains at the status report page.
Comment #59
mikeytown2 CreditAttribution: mikeytown2 commentedYou don't need to turn on Drupal's CSS optimization feature in order for CSS Embedded Images to work with this patch applied. AdvAgg is a completely different Aggregation approach compared to Drupal core. If you do enable core's CSS optimization; it is wasted cycles, we never use it's output. In short ignore the readme, I haven't patched that yet so say otherwise.
Comment #60
mikeytown2 CreditAttribution: mikeytown2 commentedReport from #1164502: Notice: Undefined index: data in css_emimage_advagg_files_table() (line 298 of css_emimage.module) PHP E' Notice
Comment #61
mikeytown2 CreditAttribution: mikeytown2 commentedAbove issue is fixed in this latest patch.
Latest snapshot and patch from fork
http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/31840ba007...
Comment #62
Peter Bowey CreditAttribution: Peter Bowey commented#61 is working for me -> advagg + css_emimage
Thanks Mike!
Comment #63
philbar CreditAttribution: philbar commented#61 still doesn't work for me.
I completely uninstalled css_emimage and then installed your fork. I also performed a "master reset" on AdvAgg cache.
All my files are still normal images.
Comment #64
aze2010 CreditAttribution: aze2010 commentedHey Folks,
cann anybody help me out?
I still got the Problems after #61.
Problem(message): "Adv CSS/JS Agg - Theme Hook Theme hook is not in the correct place."
I do have patched an got the latest dev's from both Moduels (CSS_Emimage and Agg).
What can i do to fix this problem?
Debug-info:
_rules_action_drupal_goto_handler
template_preprocess
template_preprocess_page
mobile_tools_preprocess_page
page_title_preprocess_page
nodewords_preprocess_page
css_emimage_preprocess_page
fusion_core_preprocess_page
content_profile_template_preprocess
ctools_preprocess_page
advagg_processor
conditional_styles_preprocess_page
cdn_preprocess_page
jquery_update_preprocess_page
i woul be much appreciated.
Many regards :-)
Comment #65
Peter Bowey CreditAttribution: Peter Bowey commented@aze2010
@philbar
Have you got the latest "css_emimage-advagg" snapshot patch from fork?
Location ->
http://drupalcode.org/sandbox/mikeytown2/1094988.git/shortlog/refs/heads...
or use: "
git clone http://git.drupal.org/sandbox/mikeytown2/1094988.git fork_of_css_embedded_images
" -- without the quotesComment #66
aze2010 CreditAttribution: aze2010 commentedyes, i do. My Drupal-Version is 6.22. What can i do else?
Thanks four your support!!!
Should i apply the patch from #61 to it?
I get a warning message that this Snapshot already has a patch applied :(.
Comment #67
mikeytown2 CreditAttribution: mikeytown2 commented@aze2010
Are you using the latest version of advagg?
Try flushing your caches, in advagg_theme_registry_alter I remove jquery_update_preprocess_page from the list; which is whats causing the status page to throw that warning.
Comment #68
aze2010 CreditAttribution: aze2010 commented@mikeytown2: YOU GOT IT! That was it! Thanky a lot.
I deactivate the Module "Jquery update".
Many many regards :-)
Comment #69
mikeytown2 CreditAttribution: mikeytown2 commentedwell, you shouldn't have to disable jquery update. All you need to do is flush your caches.
Comment #70
mikeytown2 CreditAttribution: mikeytown2 commentedChanging status due to #63; looks like I missed something.
Comment #71
alexbk66- CreditAttribution: alexbk66- commentedMike, I'm afraid it's not working for me at all now. I redesign my site, so I installed 6.x-2.2 (no any patches applied), cleared caches (in phpMyAdmin to be sure).
I didn't enable advagg yet. Still all images are normal files. I even tried disabling jquery update :)
I was playing with .htaccess, not sure if it could cause issues, just in case attached.
Can you please advise.
Comment #72
alexbk66- CreditAttribution: alexbk66- commentedI installed the patch http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/31840ba007..., ran update.php, but still the same.
Comment #73
mikeytown2 CreditAttribution: mikeytown2 commentedAbove issue is fixed in this latest patch.
Latest snapshot and patch from fork
http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/f564ab3be2...
Comment #74
alexbk66- CreditAttribution: alexbk66- commentedThank Mike, you are a gentleman!
Comment #75
philbar CreditAttribution: philbar commented#73 - Works for me!
Comment #76
mikeytown2 CreditAttribution: mikeytown2 commentedFixed an issue with a potential race condition. #1197280: race condition
Latest snapshot and patch from fork
http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/e65b10d4f6...
Comment #77
mikeytown2 CreditAttribution: mikeytown2 commentedfound a bug with bundles not getting incremented
Comment #78
mikeytown2 CreditAttribution: mikeytown2 commentedsite in question was using older code. putting this back to needs review
Comment #79
mikeytown2 CreditAttribution: mikeytown2 commentedComment #80
Vacilando CreditAttribution: Vacilando commentedAlso expecting this patch to be applied to the module...
Comment #81
mikeytown2 CreditAttribution: mikeytown2 commentedfixed a php Warning in this latest patch. View the patch level diff.
Latest snapshot and patch from fork
http://drupalcode.org/sandbox/mikeytown2/1094988.git/snapshot/363fd8d6e8...
Comment #82
vasrush CreditAttribution: vasrush commented#81 works great for me.
Mickey
thanks for your efforts.
Comment #83
omega8cc CreditAttribution: omega8cc commentedWe are using this forked version for months on many sites and it works great.
Please accept this tested patch.
Comment #84
jvieille CreditAttribution: jvieille commentedUsing the fork successfully too - waiting for the updated module
Thanks
Comment #85
mikeytown2 CreditAttribution: mikeytown2 commentedAdded this to the patch #1282154-29: using advagg_css_extra_alter() in fusion_core template.php for IE's conditionals
Comment #86
jvieille CreditAttribution: jvieille commentedmikeytown2 please clarify
Was this patch committed at the same time than
http://drupal.org/node/1282154#comment-5416316 ?
In other words, would the last dev support for advagg's hooks?
Update: looking at the main page, the last dev is still one year old.
Can we have all this committed?
Thanks
Comment #87
mikeytown2 CreditAttribution: mikeytown2 commentedI have git access now, this will hopefully be committed sooner rather than later.
Comment #88
jvieille CreditAttribution: jvieille commentedAny hope this will be committed soon?
Thanks
Comment #89
jvieille CreditAttribution: jvieille commentedReminder
Thanks
Comment #90
hachreak CreditAttribution: hachreak commented+1
I'd like to use this module with advagg! :)
Comment #91
jvieille CreditAttribution: jvieille commentedthe maintainer did not participate in this flourishing post since the April 2011.
Do we have to give up using this module?
Is this module abandoned?
Comment #92
Peter Bowey CreditAttribution: Peter Bowey commentedVery likely!
History shows this:
----------------------------------------------
Maintainers for CSS Embedded Images
jcarnett - 50 commits
last: 1 year ago, first: 2 years ago
All issues
17 open, 44 total
Bug reports
11 open, 23 total
----------------------------------------------
Ideal time for a new maintainer for http://drupal.org/project/css_emimage
But I suspect it will be abandoned.
The last found post by the current maintainer is:
http://drupal.org/node/1091704#comment-6325850
Comment #93
mikeytown2 CreditAttribution: mikeytown2 commentedCommitted #85
http://drupalcode.org/project/css_emimage.git/commit/09c756c0a82e456de83...
Comment #94
omega8cc CreditAttribution: omega8cc commentedFinally! Thank you!
Comment #95
hachreak CreditAttribution: hachreak commentedThank you!
When we can download the new release? :D
Comment #96
jvieille CreditAttribution: jvieille commentedIts is committed, the last dev works for me.
Comment #98
SocialNicheGuru CreditAttribution: SocialNicheGuru commentedis this patch needed if you are using Drupal 7? On my status page it says it should be applied and brings me to this issue.