Recent commits changed all the PHP files from:

      <-- blank line here
/**
 * @file
 * Pathauto integration for core modules.
 *
 * @ingroup pathauto
 */

// Rest of file...

to

/**
 * @file
 * Pathauto integration for core modules.
 *
 * @ingroup pathauto
 */

// Rest of file...

I find this change unnecessary and sticks out like a sore thumb when first opening a file. We don't have a specific coding standard regarding this specific detail (blank lines after opening PHP tag), but I always think it is best to follow the example set by core, which always has blank line after it's opening PHP tag and the first line of code/docs. I find it is more readable this way too. I'd like to revert this change.

Comments

greggles’s picture

Agreed.

Dave Reid’s picture

greggles’s picture

Thanks, Dave.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

neclimdul’s picture

Status: Closed (fixed) » Needs work

Actually, the change was technically correct. The space was sort of a bug in the way the git migration converted files and is a false standard generally kept around. Its not actually a coding standard documented anywhere.

Dave Reid’s picture

Status: Needs work » Closed (fixed)

It is the standard set by Drupal core PHP files. This does not need to be discussed further.

neclimdul’s picture