Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Recent commits changed all the PHP files from:
<-- blank line here
/**
* @file
* Pathauto integration for core modules.
*
* @ingroup pathauto
*/
// Rest of file...
to
/**
* @file
* Pathauto integration for core modules.
*
* @ingroup pathauto
*/
// Rest of file...
I find this change unnecessary and sticks out like a sore thumb when first opening a file. We don't have a specific coding standard regarding this specific detail (blank lines after opening PHP tag), but I always think it is best to follow the example set by core, which always has blank line after it's opening PHP tag and the first line of code/docs. I find it is more readable this way too. I'd like to revert this change.
Comments
Comment #1
gregglesAgreed.
Comment #2
Dave ReidCommitted restoration of the blank lines in PHP files only:
http://drupalcode.org/project/pathauto.git/commit/adf5011
http://drupalcode.org/project/pathauto.git/commit/0642e13
http://drupalcode.org/project/pathauto.git/commit/27cfef7
Comment #3
gregglesThanks, Dave.
Comment #5
neclimdulActually, the change was technically correct. The space was sort of a bug in the way the git migration converted files and is a false standard generally kept around. Its not actually a coding standard documented anywhere.
Comment #6
Dave ReidIt is the standard set by Drupal core PHP files. This does not need to be discussed further.
Comment #7
neclimdulstarted a core discussion of the issue #1339022: Standardize yes/no on empty line before the @file docblock