We don't seem to be able to test branches that don't have a proper 6.x or 7.x branch name.

Discovered on #1076584: Branch tests fail on Privatemsg master.

I recommend that we just go through the 90+ testable projects and fix the branches. 'master' should not be used anywhere that testing is turned on.

Also, probably *all* branches are being currently tested for no reason, and failing.

Files: 

Comments

boombatower’s picture

Subscribe

rfay’s picture

The other implication of this... The hook that submits branch tests on commit needs to be more selective about what it tries to test.

eliza411’s picture

This is something I could probably help with. Do you have a list of the 90+ testable branches and a procedure in mind for working with the module maintainers?

rfay’s picture

nid title project version ReleaseNode
3277 Poormanscron http://drupal.org/node/3277 7.x-2.x-dev http://drupal.org/node/94374
3281 Project http://drupal.org/node/3281 6.x-1.x-dev http://drupal.org/node/357811
8404 CAPTCHA http://drupal.org/node/8404 7.x-1.x-dev http://drupal.org/node/723600
12875 Content translation http://drupal.org/node/12875 7.x-2.x-dev http://drupal.org/node/673152
38678 Nodequeue http://drupal.org/node/38678 7.x-2.x-dev http://drupal.org/node/95884
41542 Porter-Stemmer http://drupal.org/node/41542 7.x-1.x-dev http://drupal.org/node/988562
59060 Taxonomy Filter http://drupal.org/node/59060 7.x-1.x-dev http://drupal.org/node/96252
79726 Chessboard Renderer http://drupal.org/node/79726 7.x-7.x-dev http://drupal.org/node/1004186
80382 Path redirect http://drupal.org/node/80382 7.x-1.x-dev http://drupal.org/node/398026
108746 Administration menu http://drupal.org/node/108746 7.x-3.x-dev http://drupal.org/node/108754
138844 Auto Assign Role http://drupal.org/node/138844 7.x-1.x-dev http://drupal.org/node/937426
148301 Version Control API http://drupal.org/node/148301 6.x-2.x-dev http://drupal.org/node/709988
165543 User Delete http://drupal.org/node/165543 5.x-1.x-dev http://drupal.org/node/165557
240806 Mollom http://drupal.org/node/240806 7.x-1.x-dev http://drupal.org/node/672784
243795 Link checker http://drupal.org/node/243795 5.x-1.x-dev http://drupal.org/node/243803
244515 Enabled Modules http://drupal.org/node/244515 7.x-1.x-dev http://drupal.org/node/764652
253481 Storm http://drupal.org/node/253481 7.x-1.x-dev http://drupal.org/node/510844
287853 Language icons http://drupal.org/node/287853 7.x-1.x-dev http://drupal.org/node/730292
340383 Profile permission http://drupal.org/node/340383 6.x-1.x-dev http://drupal.org/node/342532
441778 Search by Page http://drupal.org/node/441778 7.x-1.x-dev http://drupal.org/node/705014
465844 Libraries API http://drupal.org/node/465844 7.x-2.x-dev http://drupal.org/node/1044008
477446 Grammar Parser http://drupal.org/node/477446 7.x-1.x-dev http://drupal.org/node/516408
488352 Skinr http://drupal.org/node/488352 7.x-2.x-dev http://drupal.org/node/644434
571608 Password change confirm http://drupal.org/node/571608 7.x-1.x-dev http://drupal.org/node/571686
597564 Blog API http://drupal.org/node/597564 7.x-1.x-dev http://drupal.org/node/597572
646198 Mongodb http://drupal.org/node/646198 7.x-1.x-dev http://drupal.org/node/646204
689342 Proxy http://drupal.org/node/689342 6.x-1.x-dev http://drupal.org/node/689344
691808 Contact http://drupal.org/node/691808 7.x-2.x-dev http://drupal.org/node/691830
730762 Selenium to SimpleTest http://drupal.org/node/730762 7.x-1.x-dev http://drupal.org/node/730770
758304 ErrorNot notifier http://drupal.org/node/758304 7.x-1.x-dev http://drupal.org/node/758314
929068 Edge http://drupal.org/node/929068 7.x-1.x-dev http://drupal.org/node/929070
985370 References http://drupal.org/node/985370 7.x-1.x-dev http://drupal.org/node/985516
986478 Dynamic properties http://drupal.org/node/986478 7.x-1.x-dev http://drupal.org/node/1005488

eliza411’s picture

Project:Drupal.org infrastructure» Git on Drupal.org
Component:Git» Tests
Assigned:Unassigned» eliza411
Category:bug» task

I'm going to put this in the Git on Drupal.org queue while I'm posting notifications since it's more of a task than a bug now. I've gotten this far today:
3277 Poormanscron http://drupal.org/node/3277 7.x-2.x-dev http://drupal.org/node/94374
#1200542: Create dev release from a properly named branch
3281 Project http://drupal.org/node/3281 6.x-1.x-dev http://drupal.org/node/357811
#1200716: Create dev release from a properly named branch
8404 CAPTCHA http://drupal.org/node/8404 7.x-1.x-dev http://drupal.org/node/723600
#1200718: Create dev release from a properly named branch
12875 Content translation http://drupal.org/node/12875 7.x-2.x-dev http://drupal.org/node/673152
sent via contact form
38678 Nodequeue http://drupal.org/node/38678 7.x-2.x-dev http://drupal.org/node/95884
#1200728: Create dev release from a properly named branch
41542 Porter-Stemmer http://drupal.org/node/41542 7.x-1.x-dev http://drupal.org/node/988562
#1200730: Create dev release from a properly named branch
59060 Taxonomy Filter http://drupal.org/node/59060 7.x-1.x-dev http://drupal.org/node/96252
#1200734: Create dev release from a properly named branch
79726 Chessboard Renderer http://drupal.org/node/79726 7.x-7.x-dev http://drupal.org/node/1004186
#1200736: Create dev release from a properly named branch
80382 Path redirect http://drupal.org/node/80382 7.x-1.x-dev http://drupal.org/node/398026
#1200740: Create dev release from a properly named branch
108746 Administration menu http://drupal.org/node/108746 7.x-3.x-dev http://drupal.org/node/108754
#1200744: Create dev release from a properly named branch
138844 Auto Assign Role http://drupal.org/node/138844 7.x-1.x-dev http://drupal.org/node/937426
#1200748: Create dev release from a properly named branch
148301 Version Control API http://drupal.org/node/148301 6.x-2.x-dev http://drupal.org/node/709988
#1200750: Create dev release from a properly named branch
165543 User Delete http://drupal.org/node/165543 5.x-1.x-dev http://drupal.org/node/165557
#1200752: Create dev release from a properly named branch
240806 Mollom http://drupal.org/node/240806 7.x-1.x-dev http://drupal.org/node/672784
#1200754: Create dev release from a properly named branch

eliza411’s picture

Lame ... I did not mean for that to be a tag.

boombatower’s picture

I am still kinda curious as to why this is the case. Last I remember the PIFT code detects the core version using the taxonomy on the release node...as it should. Depending on the branch name is silly. Is there something else I am not remembering?

Having the branches renamed makes sense since that is the new standard, but the testbot being the reasons seems a bit off.

boombatower’s picture

Confirmed the code:

<?php
   
// Attempt to determine the Drupal core API version.
   
$api = array();
    foreach (
$branch->taxonomy as $tid => $term) {
      if (
in_array($tid, $api_versions)) {
       
$api['version'] = array_shift(explode('.', $term->name, 2));
       
$api['tid'] = $term->tid;
        break;
      }
    }
?>
boombatower’s picture

If anything based on reading some of the reported problems this was stale branch records as I mentioned during the change. Aka a commit needed to be made to resend the release information with the updated branch (aka HEAD -> master).

rfay’s picture

The reality is I don't remember the outcome or context of #1076584: Branch tests fail on Privatemsg master

boombatower’s picture

Title:All testable projects should have "master" renamed to appropriate branch» Projects should have "master" renamed to appropriate branch

Not that it's a big deal, but based on #13 seems like this may have just been a transitory problem.

sun’s picture

Nevertheless, this initiative is probably worth to continue. Putting code and naming branches after core compatibility sounds like the only proper standard all of contrib should adopt.

boombatower’s picture

Completely agree.

peterx’s picture

The pages you see when setting up a sandbox do not have a definitive statement about this issue. There is a page that pops up in searches saying you should create a new branch then delete the master branch. Renaming sounds more logical and efficient.