Need to add support for git checkouts.

CommentFileSizeAuthor
#8 add_git_clone_support.patch9.34 KBandrechun

Comments

alexkb’s picture

I've only had a brief browse over the reports generated from hacked, but yeah, its showing just about everything as 'changed'. Looking briefly over the sourcecode too, it uses a lot of cvs commands. Does the maintainer know about this, and is he/she planning to fix? Otherwise, we should get working on a patch quick smart.

steven jones’s picture

CVS commands being all over the sourcecode is intentional, as Hacked! supported diffing CVS checkouts of modules. This feature will not be removed just because d.o has switched to git, there are a lot of CVS checkouts still out there!

This issue is about adding some sort of git support, though I'm not sure what that support needs to be.

steven jones’s picture

Version: 6.x-2.x-dev » 7.x-2.x-dev
steven jones’s picture

Status: Active » Postponed (maintainer needs more info)

Need a stable version of http://drupal.org/project/git_deploy before we can implement this, and even then it's going to be tricky tricky!

Raf’s picture

I've checked for git libraries for PHP, in order to solve the CVS / Windows problem, and came across this:
http://code.kbjrweb.com/pages/project/gitphp

Haven't tried it out myself, but it seems pretty straight-forward to use and useful enough for this project (in case you don't want to be dependant of other modules -- which might be good for a module that checks if other modules are hacked ;) ).

The git_deploy project uses the Glip library.

And... according to http://mail.kde.org/pipermail/owncloud/2011-May/000591.html it might be a problem doing a diff with Glip...

lyricnz’s picture

git_deploy 2.x no longer uses the glip library, and has a stable release.

andrechun’s picture

I am currently writing some code trying to make this work. Hopefully I can have it ready for testing sometime this week.

andrechun’s picture

StatusFileSize
new9.34 KB

Here is my attempt of trying to add this feature.

You will need the latest git_deploy 2.x module in order for it to work.

steven jones’s picture

Status: Postponed (maintainer needs more info) » Needs review

Thanks for working on this!

steven jones’s picture

Issue summary: View changes
Priority: Normal » Critical
Related issues: +#1835444: Support the new dev info strings
colan’s picture

ivnish’s picture

Status: Needs review » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.