Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.
I've only had a brief browse over the reports generated from hacked, but yeah, its showing just about everything as 'changed'. Looking briefly over the sourcecode too, it uses a lot of cvs commands. Does the maintainer know about this, and is he/she planning to fix? Otherwise, we should get working on a patch quick smart.
CVS commands being all over the sourcecode is intentional, as Hacked! supported diffing CVS checkouts of modules. This feature will not be removed just because d.o has switched to git, there are a lot of CVS checkouts still out there!
This issue is about adding some sort of git support, though I'm not sure what that support needs to be.
Haven't tried it out myself, but it seems pretty straight-forward to use and useful enough for this project (in case you don't want to be dependant of other modules -- which might be good for a module that checks if other modules are hacked ;) ).
Comments
Comment #1
alexkb commentedI've only had a brief browse over the reports generated from hacked, but yeah, its showing just about everything as 'changed'. Looking briefly over the sourcecode too, it uses a lot of cvs commands. Does the maintainer know about this, and is he/she planning to fix? Otherwise, we should get working on a patch quick smart.
Comment #2
steven jones commentedCVS commands being all over the sourcecode is intentional, as Hacked! supported diffing CVS checkouts of modules. This feature will not be removed just because d.o has switched to git, there are a lot of CVS checkouts still out there!
This issue is about adding some sort of git support, though I'm not sure what that support needs to be.
Comment #3
steven jones commentedComment #4
steven jones commentedNeed a stable version of http://drupal.org/project/git_deploy before we can implement this, and even then it's going to be tricky tricky!
Comment #5
Raf commentedI've checked for git libraries for PHP, in order to solve the CVS / Windows problem, and came across this:
http://code.kbjrweb.com/pages/project/gitphp
Haven't tried it out myself, but it seems pretty straight-forward to use and useful enough for this project (in case you don't want to be dependant of other modules -- which might be good for a module that checks if other modules are hacked ;) ).
The git_deploy project uses the Glip library.
And... according to http://mail.kde.org/pipermail/owncloud/2011-May/000591.html it might be a problem doing a diff with Glip...
Comment #6
lyricnz commentedgit_deploy 2.x no longer uses the glip library, and has a stable release.
Comment #7
andrechun commentedI am currently writing some code trying to make this work. Hopefully I can have it ready for testing sometime this week.
Comment #8
andrechun commentedHere is my attempt of trying to add this feature.
You will need the latest git_deploy 2.x module in order for it to work.
Comment #9
steven jones commentedThanks for working on this!
Comment #10
steven jones commentedComment #11
colanComment #12
ivnishAutomatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.