The following two lines ar from system.module (line 1806-1807 in rc1):

> 'Select_full_join' => t(' The number of joins without an index; should be zero.'),
> 'Select_range_check' => t('The number of joins without an index; should be zero.'),

The first line has a leading space which shouldn't be there, and in addition, the two lines have the same description.

CommentFileSizeAuthor
#8 sytem.admin_.inc_.patch833 byteszeta ζ
#6 sytem.admin_.inc_.patch810 byteszeta ζ
#1 system.patch_2.txt732 bytesjax

Comments

jax’s picture

jax commented
Status: Active » Needs review
StatusFileSize
new system.patch_2.txt732 bytes

Removed the leading space. That's what I call "polish".

perf’s picture

perf commented

But should the descriptions really be the same? To me 'Select_range_check' doesn't sound like it has anything to do with joins. Judging from http://drupal.org/node/103327, it ought to be something like this:

The number of joins without keys that check for key usage after each row. (If this is not 0, you should carefully check the indexes of your tables.)
dries’s picture

dries commented

I removed that space but we'll want to double-check the explanation of those variables. The descriptions are on mysql.com somewhere ...

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Needs work
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: Typo in system.module » Full join and range check have same description

More descriptive title.

zeta ζ’s picture

zeta ζ commented
Version: 5.x-dev » 6.0-rc2
Assigned: Unassigned » zeta ζ
Status: Needs work » Needs review
StatusFileSize
new sytem.admin_.inc_.patch810 bytes

I think this is the correct description (from MySQL manual)

jax’s picture

jax commented
Status: Needs review » Needs work

The description you provided is for "Select_full_range_join" and not "Select_range_check". The description in the manual for Select_range_check is:

The number of joins without keys that check for key usage after each row. If this is not 0, you should carefully check the indexes of your tables.
zeta ζ’s picture

zeta ζ commented
Status: Needs work » Needs review
StatusFileSize
new sytem.admin_.inc_.patch833 bytes

Sorry about that: slight confusion while I was looking up the answer.

Please find corrected patch. I’ve used the description from MySQL abbreviated as per the others: Please say If you’d like a version further edited.

jax’s picture

jax commented
Status: Needs review » Reviewed & tested by the community

lgtm

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks.

zeta ζ’s picture

zeta ζ commented

Thanks,

Have you seen http://drupal.org/node/212233 ? – highlights the should be zero rows, when not zero.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.