when the domain access is enabled and each site has it's own site logo, the invoice takes the logo from the wrong site.
1. create a site 1 e.g. site1.mysite
2. create a second site 2 e.g. site2.mysite
3. choose different default themes for each of the sites from admin -> site building -> domains -> (theme link for the domain)
4. set different logos for each of the site
5. now place an order in site 2 and view the order
6. click on invoice tab. the logo of site 1 is shown instead of site 2's logo

#1 ubercart-1069590.patch1.07 KBsukr_s
FAILED: [[SimpleTest]]: [MySQL] Invalid patch format in ubercart-1069590.patch. View


sukr_s’s picture

1.07 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid patch format in ubercart-1069590.patch. View

I'm providing the patch that resolves this issue. would be great if someone could review and integrate the patch.

longwave’s picture

Status: Active » Closed (won't fix)

The wrong logo will still be displayed if you place an order on site 2, then go to site 1's admin pages and view the order. http://drupal.org/project/uc_domain fixes this issue and also other issues with order tokens so the invoice is always correct for the domain where the order was placed.

longwave’s picture

Status: Closed (won't fix) » Needs review

Hm, but $theme_key could still be a better way of finding the current domain than using variable_get(). I will look at this further when I get time, but uc_domain is still the better solution for using Domain Access with Ubercart.

TR’s picture

Version: 6.x-2.3 » 6.x-2.x-dev
Status: Needs review » Needs work

Let's get the bot to test this.

TR’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, ubercart-1069590.patch, failed testing.

longwave’s picture

Status: Needs work » Fixed

Committed a simplification for the site-logo token in http://drupalcode.org/project/ubercart.git/commitdiff/b150b22 which fixes this issue. The original code copied theme_get_setting(), but instead we can just call theme_get_setting().

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.