Reviewed & tested by the community
Project:
DFP Small Business (Google Ad Manager)
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Anonymous (not verified)
Created:
22 Feb 2011 at 10:03 UTC
Updated:
20 Oct 2018 at 13:53 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jcisio commentedPlease test with the latest -dev version.
Comment #2
Anonymous (not verified) commentedDidn't worked. I see the following code only:
Comment #3
jcisio commentedGo to the GAM settings page, there are a few options for that.
The documentation (in both README and handbook page) is poor, feel free to suggestion any change.
Comment #4
Anonymous (not verified) commentedI think I've activated them well. Check the attachment.
Comment #5
jcisio commentedOk, it looks like a bug, but I'm not sure if I can reproduce this. Do you have any other modules? Are you using a module that override the node render page (like Panels or a module using CTools page manager)?
Comment #6
Anonymous (not verified) commentedYep, I have CTools, Panels, Display Suite running on latest versions
Comment #7
jcisio commentedPut this somewhere in the .module file and test:
It is untested, but it should work.
Comment #8
Anonymous (not verified) commentedBrillian! It worked. Thank you very much. Will you add this to future versions?
BTW, do you know a way to pass these arguments from Panel Pages?
Comment #9
jcisio commentedI'll commit this fix into CVS later and it will be included in future versions.
Comment #10
jcisio commentedI totally forgot about this one and it missed 6.x-2.3 release! However I've just committed this patch. Switch to D7 branch where Panels is still in alpha stage.
Comment #11
jcisio commentedEven the feature does currently not exist in D7 (the port was not complete), so I postpone.
Comment #12
jcisio commentedComment #13
Darren Shelley commentedTo anyone landing here hoping for a d7 solution this works:
Comment #14
Anonymous (not verified) commentedDoes the latest 6.x-2.x-dev includes this patch?
Comment #15
jcisio commentedIIRC and what I said in #10 is right, this issue is fixed in 6.x-2.x-dev.
For 7.x, #1251882: Targeting specific taxonomy terms should get in before this issue. Thanks to Darren, but I really don't have time right now and it needs someone else review.
Comment #16
axel pressbutton commentedThe solution highlighted by Darren in #13 works for me but It throws the following notice in php5.3:
"Notice: Undefined index: admin path in google_admanager_ctools_render_alter()"
So i have ammended the code to check whether admin path is set before validating whether it matches node/%node:
Comment #17
jcisio commentedRTBC from #13 and #16.
What I said in #15 about #1251882: Targeting specific taxonomy terms is not correct, because at least we can already expose node type...