Table caption mentioning click_insert should only be visible with JS on [#1067238]

I just tried out embedding a token_tree in a module admin page and, while it was pretty simple and awesome, I wasn't able to click_insert tokens like it said at the top of the table.
I then realized that I didn't have JS on, which is why it didn't work (with JS it works beautifully), but it was weird that the table told me it would work.
Attached patch adds the 'element-hidden' class to the caption and removes that via JS, so that the caption is only shown with JS on. It then leaves a useless < span > laying around, but I'm not sure whether/how it's possible to add attributes to the caption itself.

Comment	File	Size	Author
#3	token-insert_click_nojs-1067238-3.patch	906 bytes	Andrew Answer
#3	7.x-1.x: PHP 5.5 & MySQL 5.5, D7 32 pass
	token_insert_click_nojs.patch	1.33 KB	tstoeckler

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

tstoeckler

he/him

German

Essen, Germany

CreditAttribution: tstoeckler commented 18 April 2011 at 08:55

Title:	Table caption mentionen click_insert should only be visible with JS on	» Table caption mentioning click_insert should only be visible with JS on
Assigned:	Unassigned	» tstoeckler

fixing title, assigning to me, and bump.

Comment #2

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented 9 January 2019 at 03:11

Assigned:	tstoeckler	» Unassigned
Issue summary:	View changes
Status:	Needs review	» Needs work
Issue tags:		+Needs reroll

1 file was hidden/shown/deleted

File	Size
token_insert_click_nojs.patch	1.33 KB

The 8 year old patch to token.pages.inc does not apply to the latest token 7.x-1.x-dev and if still applicable needs reroll.

Checking patch token.js...
Hunk #1 succeeded at 4 (offset -1 lines).
Checking patch token.pages.inc...
error: while searching for:
    'empty' => t('No tokens available.'),
  );
  if ($variables['click_insert']) {
    $table_options['caption'] = t('Click a token to insert it into the field you\'ve last clicked.');
    $table_options['attributes']['class'][] = 'token-click-insert';
  }

error: patch failed: token.pages.inc:90
error: token.pages.inc: patch does not apply