Currently, if the system $PATH (*nix/Mac) or %PATH% (Windows) variables are not configured correctly, Fill PDF will not raise an alert. This should be changed so that it does. The first place for this would be the configuration screen. Following that, another one upon a failed PDF parse would also be helpful.

Patches welcome.

CommentFileSizeAuthor
#6 fillpdf_pdftk_path_check.patch1.57 KBliam morland
#3 fillpdf_pdftk_path_check.patch1.64 KBliam morland
#1 fillpdf_pdftk_path_check.patch2.41 KBliam morland

Comments

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new fillpdf_pdftk_path_check.patch2.41 KB

The attached patch does the check when pdftk is used. Only tested on Linux.

I will do the test on the settings page as part of working on #1355018: Settings page behavior is confusing.

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Status: Needs review » Needs work 
+++ b/fillpdf.moduleundefined
@@ -378,7 +378,7 @@ function fillpdf_merge_pdf($fid, $nids = null, $webform_arr = null, $sample = nu
-  if (!empty($node)) { 
+  if (!empty($node)) {

Style fixes are separate patches.

---

Otherwise, I'm fine with this patch, so I will commit it on the next re-roll, provided that nothing else comes up with it. It would also be good to have a check for this on the settings page, which was my original thought. Perhaps include that one in this patch instead of that patch.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs work » Needs review
StatusFileSize
new fillpdf_pdftk_path_check.patch1.64 KB

Updated patch attached.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Settings page check done as part of #1355018: Settings page behavior is confusing.

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Needs review » Patch (to be ported)

Committed in 6bfc7f5 and needs backport.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new fillpdf_pdftk_path_check.patch1.57 KB

D6 patch attached.

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Status: Needs review » Fixed

Committed in 2b7c69f.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 5bfc7f5 on 7.x-1.x, 7.x-2.x, 7.x-2.x-tests1, 7.x-1.x-ubercartbackporttest authored by Liam Morland, committed by wizonesolutions: 
    Issue #1066172: Produce additional pdftk warnings if configured...