Closed (fixed)
Project:
Project issue tracking
Version:
6.x-1.x-dev
Component:
Issues
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
18 Feb 2011 at 19:43 UTC
Updated:
26 Mar 2011 at 04:21 UTC
Jump to comment: Most recent file
Comments
Comment #1
dwwThis is one of those cases where you can get to a page from two paths:
A) /node/add -> project_issue
B) /project/issues/[project-name] -> create issue
So, it's not obvious what the breadcrumb should really be. It's currently handling case A. You're saying it should handle B. I suppose B is a lot more common, especially on d.o, but that's not always true. I'm not sure this is really a win for project_issue itself, although it certainly highlights the problem of what to do with breadcrumbs on pages that have multiple entry points...
Can you further expalin what "a bit better" means and why it's worth changing this?
Regardless, I don't want to commit and deploy this until after the Git launch so as not to add any new variables or confusion to an already complicated launch. Just created myself a TODO to revisit this a week from Monday (when the dust will hopefully be fully settled from the Git launch)...
Comment #2
drummYes, that's all completely true. For Drupal.org, if you start at http://drupal.org/node/add/project-issue/drupalorg and click "Create a new issue," I would expect the same navigation to be used on both pages.
Comment #3
dww@drumm: Yup. And if you start at:
http://drupal.org/node/add
and click on "Project issue"
I would expect the same navigation to be used on both pages. ;)
Hence, the problem. ;) But, I guess your argument is that nothing links to http://drupal.org/node/add directly, so people manually typing that in get what they deserve. The http://drupal.org/node/add/project-issue UI totally sucks, too.
So, I guess we could optimize this for d.o's navigation, but that's a bit unfortunate. Maybe a setting so folks can choose? There's no sane way to alter this, right?
Comment #4
drummYou can alter it by calling drupal_set_breadcrumb() again. This doesn't seem like something that users would want to customize, I don't think a setting would be appropriate. But, I don't have any experience with how people are using project outside of Drupal.org. I think this definitely makes sense for Drupal.org, but will other sites like it, want to change it, or even notice?
Comment #5
drummOh, I do have experience on security.drupal.org, but don't file many issues. I imagine I have another tab(s) open for the project; if I don't, having a link to open in a new tab would be handy if I need to look something up. Same for Drupal.org.
Comment #6
dwwYeah, that settles it. We want to associate creating issues with looking for/at issues as much as possible, so it makes more sense to group this with the project, not the generic /node/add world. I'll commit probably later tonight (gotta run to a rehearsal right now).
Comment #7
drummGit-formatted patch for the drupalorg half, since I migrated my drupalorg working copy.
Comment #8
dwwReviewed, tested, committed and pushed for both project_issue and drupalorg.
Just awaiting deployment now.
Thanks!
-Derek
Comment #9
dwwThis broke breadcrumbs when viewing issues themselves (no link back to the issue queue) since the comment form displayed on issue nodes is re-using the issue form (to get all those form elements) and that form was setting the breadcrumb directly (ugh). Fixed, tested, pushed upstream, imported into vendor, and deployed.