PHP warnings when posting a comment. [#1062780]

* Notice: Undefined variable: unpublished in include() (line 3 of /home/xxx/xxx.com/sites/all/themes/omega/omega/omega/templates/comment.tpl.php).
* Notice: Undefined variable: datetime in include() (line 21 of /home/xxx/xxx.com/sites/all/themes/omega/omega/omega/templates/comment.tpl.php).

I did also notice all the omega folders, this happened when I upgraded from beta 1 --> beta 2 using drupals update function.

Comment	File	Size	Author
#3	1062780.patch	540 bytes	himerus

Comments

Comment #1

himerus commented 15 February 2011 at 23:10

Sadly, the update functions in core has a bug when using a theme like Omega, Fusion, or Adaptive Theme that store multiple themes (base, starterkit, etc) in the root directory of the theme....

The following issue demonstrates it: http://drupal.org/node/986616

Please remove the omega folder completely and download new version. I have to remove and redownload even via Drush too until this bug is fixed in core's update functionality.

If you can test that, and if the error persists, I'll look further into it.

Comment #2

tchilly commented 15 February 2011 at 23:38

Still getting the errors :(
Did as you said remove the old folder, downloaded and extracted the beta 2.

* Notice: Undefined variable: unpublished in include() (line 3 of /home/xxx/xxx.com/sites/all/themes/omega/omega/templates/comment.tpl.php).
* Notice: Undefined variable: datetime in include() (line 21 of /home/xxx/xxx.com/sites/all/themes/omega/omega/templates/comment.tpl.php).
* Notice: Undefined variable: unpublished in include() (line 3 of /home/xxx/xxx.com/sites/all/themes/omega/omega/templates/comment.tpl.php).
* Notice: Undefined variable: datetime in include() (line 21 of /home/xxx/xxx.com/sites/all/themes/omega/omega/templates/comment.tpl.php).

Comment #3

himerus commented 15 February 2011 at 23:58

Status:

Active

» Needs review

Status	File	Size
new	1062780.patch	540 bytes

This patch seems to solve the issue (i was able to replicate the issue locally)

The following code needs to be added to omega/omega/preprocess/preprocess-comment.inc

$vars['datetime'] = format_date($vars['comment']->created, 'custom', 'c');
$vars['unpublished'] = '';
if ($vars['status'] == 'comment-unpublished') {
  $vars['unpublished'] = '<div class="unpublished">' . t('Unpublished') . '</div>';
}