Given that #994244: Rename the master branch to a proper version branch is won't fix, and given #1059072: Migrate away from the use of master branch: Document and promote project moves it looks like we want to re-add the special case when editing release nodes that currently point to HEAD/master to allow release maintainers to move the release node to point to a specific branch that maps to the same version info. This code wasn't originally left in the vc_release release node form stuff given #953916: Proposal: Ditch the ability to have release nodes pointing to HEAD/master however it seems we need it back. I'll be working on this now...
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 1061592-2.edit-release-master-branch.patch | 4.77 KB | dww |
Comments
Comment #1
rfaysubscribe. Thanks!
Comment #2
dwwOkay, this should do it, based on local testing. However, I'd like to try it on git-dev to be sure. ;)
While working on this, I noticed a bug in the existing code which this patch also fixes. There's a PHP notice in project/release/includes/release_node_form.inc when saving a release node edit, since the 'tag' value is no longer present in $form_state['values'] where project_release is looking for it. The result is that the value in {project_release_nodes}.tag gets emptied, which is problematic for packaging. So, this patch also fixes that bug.
Comment #3
dwwCommitted to HEAD of vc_project. I believe this will automatically get deployed on the next git-dev rebuild. I can manually deploy this sooner if needed.