Closed (outdated)
Project:
BeautyTips
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
13 Feb 2011 at 13:15 UTC
Updated:
11 Feb 2018 at 16:56 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
kleinmp commentedIt's a deal. When I get a chance, I'll do this but I'm also open to patches.
Comment #2
aspilicious commentedHere is an untested patch (I think it should work but I can have made some typos)
Comment #3
aspilicious commentedComment #4
aspilicious commentedTested a bit, and isn't working somehow hook_librar doesn't get called :(
Comment #5
aspilicious commentedThis is a first working step.
Only the IE stuff isn't working yet.
(This also contains the fixes needed to install beautytips in D7 without problems, see other issue)
Comment #6
aspilicious commentedComment #7
xurizaemonCan you elaborate on "the IE stuff isn't working yet"?
I stopped being excited about IE when the ability to change frameborder colours wore off, but if this doesn't work for IE then it's still "Needs Work" IMO.
Comment #8
aspilicious commented+ //for IE add this
+ $expath = $path . '/other_libs/excanvas_r3';
+ if (count(file_scan_directory($expath, '/excanvas.compiled.js/', $options = array('recurse' => FALSE)))) {
+ $jsPath = array($expath . '/excanvas.compiled.js' => array());
+ array_merge($javascript, $jsPath);
+ }
this doesn't work yet (I think, its been a while since I looked at this)
Comment #9
xurizaemonI think that code shouldn't use file_scan_directory with recurse and then assume the found file is at the top of the path?
This code adds the IE conditional tags for excanvas in D7. But I don't know how libraries module handles IE conditional tags, or if the excanvas reference should go in a separate library folder etc.
Comment #10
kleinmp commentedI used the above patch, got the excanvas library loading, and committed this to the 7.x-2.x-dev branch. Please reopen if this does not work for you.
Comment #12
socialnicheguru commentedwhere do I place the excanvas folder now?
Comment #13
Adam S commentedI'm developing on Windows 7. Oh, joy! The file_exists() function doesn't work on Windows well. Doesn't the Libraries module have a mechanism to check this without using file_exists()? Also, for convention sake should the excanvas library be placed in sites/all/libraries for convention sake?
Comment #14
kleinmp commentedThe libraries api module uses file_exists in a bunch of places and it's used all over the place elsewhere in Drupal. If we can identify what's causing the file_exists to fail in Windows, then we can probably make it work.
Right now, it's checking the file starting from the drupal root, but it could check from the root of the disk using DRUPAL_ROOT constant. I don't have a good way of checking if this works in Windows or not.
Yeah, the excanvas should go into sites/all/libraries. Both of these items should probably be separate issues.
Comment #15
hefox commentedRe-open reason for this issue sounds like a new bug report, no?
Else there'd be no need for new issues, everyone would just re-open an the original feature request when they find any bug.
"needs work" with this issue title does not convey what the current is, at least.
Comment #16
pifagor commented