Display a message when removing elements from cart

This won't work because it supposes that field will always be used to remove an item from the shopping cart. Instead, what needs to happen is the field's submit handler should just have a generic "Line item deleted." message when a remove button is clicked, but it should happen in its own submit handler so it can be overridden by the cart form to use a submit handler with a cart specific message.

You can see an example of this with the save button for the form. The submit array for the button specifies a separate submit handler found in commerce_line_item.module that displays the save message:

  $form['actions']['update'] = array(
    '#type' => 'submit',
    '#value' => t('Save'),
    '#submit' => array_merge($form['#submit'], array('commerce_line_item_line_item_views_form_submit')),
  );

The cart module alters the button's value and its #submit array to use a different submit handler for the message:

    // Change the Save button to say Update cart.
    $form['actions']['update']['#value'] = t('Update cart');
    $form['actions']['update']['#submit'] = array_merge($form['#submit'], array('commerce_cart_line_item_views_form_submit'));

When you give this another shot, just go ahead and wipe your branch and start over so I don't have to pull in this commit with the final solution.

Not quite there yet... you're getting the idea, but you're still referencing a "cart" from the line item module. The message in the default submit handler should just be "Line item deleted.", and the Cart module can alter the #submit array to use a different message submit handler about removing the item from the cart.

The first code block in my comment above was from the Line Item module, but the second one was from the Cart module.

Cool. Looking much closer - I don't understand why you put the wrapper into the $form_state, though. : ?

Oooh, good point. Didn't think of that. ; )

Maybe we just want to store the title or something then? Or, actually, if we store the line item itself, it can still be wrapped on submit. The wrapper doesn't depend on any data coming from the database.

I've tested it and it works.

Thanks for the patch and review. Committed.