Strict warning: Declaration of FeedsDateTime::setTimezone() should be compatible with that of DateTime::setTimezone() [#1055582]

Comment	File	Size	Author
#7	1055582-strict-warning-for-feedsdatetime-settimezone-7-D7.patch	1014 bytes	milesw

Comment #1

ickx17 CreditAttribution: ickx17 commented 28 February 2011 at 10:18

Same error:

Strict warning: Declaration of FeedsDateTime::setTimezone() should be compatible with that of DateTime::setTimezone() in _registry_check_code() (line 2789 of [my_base_path]\includes\bootstrap.inc).

Don't know how to fix, please help!

Log in or register to post comments

Comment #2

datorres CreditAttribution: datorres commented 3 March 2011 at 15:30

I have the same error.

Strict warning: Declaration of FeedsDateTime::setTimezone() should be compatible with that of DateTime::setTimezone() en _registry_check_code() (línea 2789 de C:\xampp\htdocs\prueba\includes\bootstrap.inc).

Log in or register to post comments

Comment #3

sonar_un CreditAttribution: sonar_un commented 8 March 2011 at 20:20

Subscribing

Log in or register to post comments

Comment #4

casey CreditAttribution: casey commented 8 March 2011 at 22:33

It doesn't look like the $force parameter is being used. So maybe it can be dropped.

If not, I reckon an extra method like forceTimeZone() could help out.

Log in or register to post comments

Comment #5

softmax CreditAttribution: softmax commented 9 March 2011 at 13:23

Subscribing

Log in or register to post comments

Comment #6

steinmb CreditAttribution: steinmb commented 29 March 2011 at 21:41

See the same warning, PHP 5.3.5. So what is the history behind $force? Changing line 600 (plugins/FeedsParser.inc) to
public function setTimezone(DateTimeZone $tz) {
remove the warning.

Log in or register to post comments

Comment #7

milesw CreditAttribution: milesw commented 6 April 2011 at 11:27

File	Size
1055582-strict-warning-for-feedsdatetime-settimezone-7-D7.patch	1014 bytes

The solution seems to be removing the type hint from the method signature. This doesn't really make sense, but it's how others are handling the issue.

Date module: #953688: Strict warning: Declaration of DateObject::setTimezone() ...
Joomla issue queue: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&...

public function setTimezone(DateTimeZone $tz, $force = FALSE)
changed to
public function setTimezone($tz, $force = FALSE)

Log in or register to post comments

Comment #8

Dave Reid

he/him

English

Nebraska USA

CreditAttribution: Dave Reid commented 6 April 2011 at 15:38

Status:

Active

» Needs work

The problem is that DateTime::setTimezone does not have a $force parameter, and therefore we can't just add an extra one when we want to if we're extending that class.

Log in or register to post comments

Comment #9

milesw CreditAttribution: milesw commented 6 April 2011 at 16:49

@Dave Reid

But that's the obvious solution, the one that makes sense. :)

On my system, running PHP 5.3.5, removing that $force parameter changes nothing. The only way I can get rid of the warning is to remove the DateTimeZone hint. I have no idea why, but it looks like the folks over at the Date module had to do the same.