i can leave version set to and it the form will still submit, even on a brand new issue where i don't use any of the ajax reload stuff. for me it's picking the last item in the select list and submitting the form

Comments

hunmonk’s picture

Version: 4.7.x-1.0 » 5.x-2.x-dev

problem exists in 4.7 and on d.o. as well...

dww’s picture

Title: version not verified » rip out bizzare "default version" behavior
Category: bug » task

actually, the problem is that there's some weird, legacy code in here so that if you try to submit an issue with a version of [none], it'll automatically submit it with the "default version", instead.

if this feature ever made sense, the default should have showed up as a #default_value in the form in the first place.

however, there's no longer any reasonable "default version", since it depends on the branch, core API, etc, etc.

i think all this code should go, so that in validate(), if we're still at [none], we should mark it as an error, not silently set the version to something else.

dww’s picture

Assigned: Unassigned » dww
Category: task » bug
Status: Active » Needs review
StatusFileSize
new1.38 KB

this is really a bug, not just a task, since $project->version is no longer controlled in any way. it's just stale info in a (should be) unused column in the {project_projects} table that might as well be dropped (the 'version' column, that is, not the table). ;)

dww’s picture

DRUPAL-4-7--2 version

dww’s picture

DRUPAL-4-7 version

greggles’s picture

Title: rip out bizzare "default version" behavior » rip out bizarre "default version" behavior

This makes sense to me. It was unexpected behavior for hunmonk and I think it makes more sense to force the user to choose the version than to just default it.

dww’s picture

Status: Needs review » Fixed

greggles agreed this was stupid, so i killed it. applied to all 3 branches.

Anonymous’s picture

Status: Fixed » Closed (fixed)