My module is printing a block with this count. The count is inaccurate after some messages change status because the static stores the incorrect count before the messages are changed.

Patch incoming.

CommentFileSizeAuthor
#4 1054206-unread_count_reset4.patch679 byteste-brian
#3 1054206-unread_count_reset2.patch1.77 KBte-brian
#1 1054206-unread_count_reset.patch871 byteste-brian

Comments

te-brian’s picture

te-brian commented
Status: Active » Needs review
StatusFileSize
new 1054206-unread_count_reset.patch871 bytes

Here's the patch.

te-brian’s picture

te-brian commented

Keep in mind that patch only 'resets' the value for the current $account. This is desirable for me because I'd rather leave the static values in place for other users.

However, it may be more 'standard' to clear the whole variable.

te-brian’s picture

te-brian commented
StatusFileSize
new 1054206-unread_count_reset2.patch1.77 KB

Based on some IRC feedback, I changed the $reset flag so it clears the whole array of counts.

Also, I added two resets: One for when a message changes status and another for when a thread changes status.

I don't feel a clear is necessary in _privatemsg_send() because the user who sent the message will not receive an unread version of it (afaik).

These clears may move depending on what is committed in #1054082: Allow modules to respond to a status change.

te-brian’s picture

te-brian commented
StatusFileSize
new 1054206-unread_count_reset4.patch679 bytes

Re-rolled and also removed the resets (per IRC discussion).

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Commited, thanks!

No need to port to D7, thanks to drupal_static_reset().

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.