It's generally accepted in 7.x to avoid calling entities by numbers. As for taxonomy vocabularies it's implemented by Features since 6.x, it's important for Feeds too. Variable names like 'taxonomy_menu_vocab_menu_1' are ugly and unusable. Patch is following.

CommentFileSizeAuthor
#4 taxonomy-menu-machine-names.patch14.19 KBbennetteson
#1 1053308_taxonomy_menu.patch642 bytestema

Comments

tema’s picture

tema commented
Status: Active » Needs review
StatusFileSize
new 1053308_taxonomy_menu.patch642 bytes

Please review.

tema’s picture

tema commented

Nice to have some appropriate hook_update_N before it's been committed.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Version: 7.x-1.1 » 7.x-1.x-dev
Status: Needs review » Needs work

This should be done anyway but this also require hook_update_N() and code cleanup allround module code

bennetteson’s picture

bennetteson commented
Status: Needs work » Patch (to be ported)
StatusFileSize
new taxonomy-menu-machine-names.patch14.19 KB

Hello,

This patch should be the good-one. Please review.

bennetteson’s picture

bennetteson commented
Status: Patch (to be ported) » Needs review

patch (to be ported) -> needs review

dstol’s picture

dstol
Primary language English
commented

AWESOME! This was way way way high up on my todo list!

dstol’s picture

dstol
Primary language English
commented
Title: Use vocabularies machine names instead of numbers » Use vocabularies machine names instead of numbers
Status: Needs review » Fixed

Thanks a lot tema and bennetteson!

http://drupalcode.org/project/taxonomy_menu.git/commit/428b60d

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.