Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I ran into this issue now on several of my drupal installations (pressflow, drupal). I don't know why and how to fix this problem but I see that piwik adds the javscript code twice in the footer. This is not really useful as it counts every user twice and slows down the page loading. Is there someone else who had problems like this?
I try to find it out, but i have no Idea where to start.
Comment | File | Size | Author |
---|---|---|---|
#9 | advagg-1051172-8.patch | 3.68 KB | mikeytown2 |
Comments
Comment #1
hass CreditAttribution: hass commentedNot by this module. It will be added once.
Try out: Disable one by one module until you found the buggy module... if it's not pressflow I guess you will find it. I would personally start with broken cufon... and do not forget to report back, please. :-)
Comment #2
broncomania CreditAttribution: broncomania commentedI think I found the problem.It looks like an advagg bug. If I enable the use Advagg in closure checkbox it gets rendered twice. The original and the compressed one are delivered.
Needs some time to found out but I think I got it!
Comment #3
broncomania CreditAttribution: broncomania commentedComment #4
hass CreditAttribution: hass commentedComment #5
broncomania CreditAttribution: broncomania commentedHmm, so I tested it again including cache clearing because I use boost and the problem only exist if I use the advagg_closure function. i disable it, but I am not sure if this is the best solution.I am wodering that I am the only one who get this effect. Any idea where to start to debugg?
Comment #6
hass CreditAttribution: hass commentedSo advagg has a bug. Moving queue.
Comment #7
mikeytown2 CreditAttribution: mikeytown2 commentedIssue has to do with drupal_add_js being in hook_footer.
http://drupal.org/project/bundlecache
http://drupal.org/project/javascript_aggregator
Will have this same issue, as all these module use the same technique to modify the footer JS to include the custom JS file instead of the normal drupal core one. Will look for ways around this in advagg; placing the piwik logic in a template_preprocess_page hook would probably fix the issue without any side effects.
Comment #8
mikeytown2 CreditAttribution: mikeytown2 commentedTested with this:
Shows up in the footer twice, rand is the same so hook only gets ran once. Bug is with advagg; digging deep
Comment #9
mikeytown2 CreditAttribution: mikeytown2 commentedCommitted this patch. Thanks for the bug report.
Comment #10
broncomania CreditAttribution: broncomania commentedThx mikeytown2!! I thought I was the only one with that problem.
Comment #12
rhylos CreditAttribution: rhylos commentedDid #9 get commited as Google Analytics (very similar to piwik in function) does the same thing. Entered twice if the addv agg has the closure enabled.