Remove unnecessary $variables['submitted'] override in template.php [#1051164]

In Bartik theme, $variables['submitted'] gets overriden in bartik_preprocess_node().
As the result is exactly the same as node module returns, i guess this is a override that can be deleted.
Small patch removes this.

Comment	File	Size	Author
	bartik_submitted.patch	626 bytes	betz

Comments

Comment #1

jensimmons commented 21 February 2011 at 21:52

Status:

Fixed

» Reviewed & tested by the community

Yeah, this override of $submitted should go.

a) If Bartik is going to redo submitted, it should have done something better! The current format is still really bad.

b) Overriding $submitted with unexpected behavior is exactly the kind of thing I kept wanting to do when creating Bartik, but webchick kept saying no. I'm surprised this got in. I'm guessing it was allowed by oversight, not consciously.

This came up as a problem for me today because the theme override is keeping HTML5 Tools from being able to override it. So here's my review:

I applied this patch cleanly. No problems with the patch.

Before:

Before the patch, it says: "published by jensimmons on Thu, 01/06/2011 - 17:11"

After:

After the patch, it says: "Submitted by jensimmons on Thu, 01/06/2011 - 17:11"

I believe we should provide an easy way for a site builder to modify this phrase. "Submitted" is geeky. "Published by" or "Written by" or simply "By" is better. But that should be a new configuration option in site settings for Drupal 8. Meanwhile, as sad as the default $submitted is, it should be the default in Bartik.