A lot of following messages was displayed when I upgrade taxonomy_access 5.x-1.1 to 6.x-1.2

user warning: Column count doesn't match value count at row 1 query: INSERT INTO editorial_term_access_defaults (vid, rid, grant_view, grant_update, grant_delete, grant_create, grant_list) VALUES (0, $row_ints) 

I examined "taxonomy_access.install" file. It seems following code was never work. Because single quoted $row_ints value was not parsed.

38:      $row_ints = implode(", ", $row);
39:      update_sql('INSERT INTO {term_access_defaults} (vid, rid, grant_view, grant_update, grant_delete, grant_create, grant_list) VALUES (0, $row_ints)');

It's a bug?

CommentFileSizeAuthor
#2 taxonomy_access-1050982.patch953 bytesmula

Comments

xjm’s picture

Status: Active » Postponed

It's probably a bug, but 5.x is EOL so I probably won't be fixing it myself.

Change status to "needs review" if you submit a patch.

mula’s picture

Priority: Normal » Minor
Status: Postponed » Needs review
StatusFileSize
new953 bytes

Thank you for your message.
I understand that it's a legacy code.
But I submit patch for all in the same boat.

xjm’s picture

Status: Needs review » Fixed

Committed to 6.x-1.x-dev:
http://drupal.org/cvs?commit=496266

mula’s picture

Thank you!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.