uc_coupon has a store dashboard menu entry at /admin/store/coupons, but cannot provide an icon because uc_store_get_icon() provides no way for this to happen. There is a comment of "See if it's hooked in anywhere else" but no actual implementation for this.

See also #1043322: Icon for the store dashboard

CommentFileSizeAuthor
#3 1043500-deprecate-uc_store_get_icon.patch3.77 KBlongwave

Comments

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: Store dashboard icons are not extensible » Remove uc_store_get_icon()
Version: 6.x-2.x-dev » 7.x-3.x-dev
Category: feature » task
Status: Active » Postponed

uc_store_get_icon() is only called three times in 7.x-3.x, let's just remove it entirely in a future version.

tr’s picture

tr commented

Yes, I agree. I thought it had been eliminated long ago when the dashboard was removed in 7.x-3.x.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: Remove uc_store_get_icon() » Deprecate uc_store_get_icon()
Status: Postponed » Needs review
StatusFileSize
new 1043500-deprecate-uc_store_get_icon.patch3.77 KB

The three places this is used:

1. In uc_shipping_select_address, where it displays an address book icon that looks out of place anyway.
2. In the "click to open a window with a printable invoice", where it can be replaced with theme('image').
3. In uc_select_address, where it displays an address book icon but is not used in core anyway.

So this patch removes all calls to uc_store_get_icon() and marks the function as deprecated.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.