Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.uc_coupon has a store dashboard menu entry at /admin/store/coupons, but cannot provide an icon because uc_store_get_icon() provides no way for this to happen. There is a comment of "See if it's hooked in anywhere else" but no actual implementation for this.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 1043500-deprecate-uc_store_get_icon.patch | 3.77 KB | longwave |
Comments
Comment #1
longwaveuc_store_get_icon() is only called three times in 7.x-3.x, let's just remove it entirely in a future version.
Comment #2
tr commentedYes, I agree. I thought it had been eliminated long ago when the dashboard was removed in 7.x-3.x.
Comment #3
longwaveThe three places this is used:
1. In uc_shipping_select_address, where it displays an address book icon that looks out of place anyway.
2. In the "click to open a window with a printable invoice", where it can be replaced with theme('image').
3. In uc_select_address, where it displays an address book icon but is not used in core anyway.
So this patch removes all calls to uc_store_get_icon() and marks the function as deprecated.
Comment #4
longwaveCommitted.