In my development site, while testing a quantity limit module as User 1, I noticed that in /cart the Update Cart button wasn't working, it would redirect back to /cart without any changes made to the quantity, so I tried the Checkout button and it would also redirect back to /cart.

Going to /cart/checkout manually works, as do the Cancel and Review Order Buttons.

Ubercart 6.x-2.x-dev (2011-Jan-24)
Signup 6.x-1.x-dev (2011-Jan-10)
Signup Integration for Ubercart 6.x-1.0-beta6

While troubleshooting this I tried running Update, clearing all caches, and disabled all known UC related modules until problem resolved - the only one that made a difference is the Signup Integration for Ubercart. Unfortunately, I don't know when this functionality was last working. It doesn't generate any errors. Note this is also independent of having a Signup product in the cart (it seems to fail regardless of product).

I tried but it still fails with uc_signup 6.x-1.x-dev (2010-Nov-12)

Any ideas or how to further troubleshoot?

Thanks!!

Comments

todd zebert’s picture

I've even tried disabling and deleting UC, Signup and Signup UC, then re-enabling them only the absolute minimum modules. No change!

teustis’s picture

following

TimelessDomain’s picture

Priority: Normal » Critical

i'm experiencing this as well.
i think it has something to do with the latest release of ubercart as the workflow has changed after being updated.
If i remember correct, upon initially adding a signup product to the cart - a user is instantly prompted to provide their email/ other info. This is no longer happening. When i go to the cart /cart and click checkout -> i get redirected back to the cart. If i type in the checkout url /cart/checkout & hit submit -> i go to the checkout page after having to fill out the signup email/ other info uc_signup/attendees/emails .
Furthermore past signups & aborted signup are being combined w/ the products in my cart here uc_signup/attendees/profiles -> and this is allowing users to purchase the old/ extra events for free. If the old events were already paid for - a "Signups are closed for this event." message appears on the review page cart/checkout/review & stops me from completing the checkout. (note: i am limiting events to 1 signup). If the old events were added to the cart, but never completely paid for, it allows you to complete the checkout & gives you these events for free (on top of the ones you paid for).

I am raising this issue to critical -> since this is breaking the functionality of this module & since it is most likely related to its compatibility w/ the latest ubercart dev. releases.

todd zebert’s picture

@TimelessDomain Wow, great help, thanks. My issue was occurring with a sandbox site which I was already recreating on a QA site, so I gave up on this issue. Although I was hoping it wouldn't reoccur. On the QA I'm using non-dev Ubercart with a couple manual patches and non-dev Signup but Signup Integration b6, so hopefully that won't break!

Anonymous’s picture

This is really critical. We have the same issue.
I hope this will be fixed soon. I can not activate this in our site and we need this badly.
Thanks

TimelessDomain’s picture

Title: Update Cart & Checkout buttons on /cart refresh page but do not work as expected » Not Compatible with Ubercart 6.x-2.x-dev - Update Cart & Checkout buttons on /cart refresh page but do not work as expected
ezra-g’s picture

This seems to be caused by the following in uc_cart.module:

    // Checkout button.
    case t('Checkout'):
      $form_state['redirect'] = variable_get('uc_checkout_enabled', TRUE) ? 'cart/checkout' : 'cart';
      break;

We probably want to move the redirect logic from uc_signup_order() case view to a shared function that can determine the redirect location for the uc_cart_view_form(), as well as being called from uc_signup_order().

ezra-g’s picture

Version: 6.x-1.0-beta6 » 6.x-1.x-dev
Status: Active » Needs work
StatusFileSize
new1.6 KB

Actually, strike the point in my previous comment about a shared function to determine where to redirect. We already do that in the uc_signup order pane, and that seems like the appropriate place.

Here's a patch that at least lets get folks to the checkout page, though we now need to implement hook_update_cart_item() to deal with item quantity changes.

I've set up a 1040970-uc-dev-cart where I'm also posting progress commits for folks who are interested. My main motivation for that branch is to make it possible to start working on #540298: Signups not created when off-site payment methods fail to call hook_order case submit..

mariagwyn’s picture

following...same problem, waiting for dev release.

ezra-g’s picture

Status: Needs work » Reviewed & tested by the community
StatusFileSize
new1.79 KB

Here's a revised version of this patch. We actually can't implement hook_update_cart_item() because uc_signup is not the owning product module for the signup-enabled products - uc_product is.

However, we can detect which button was used to submit the update cart form and update the $_SESSION information accordingly. I've revised and tested this patch with items being removed from the cart, changed quantities, and quantities set to 0.

I think this is RTBC.

ezra-g’s picture

Status: Reviewed & tested by the community » Fixed
ezra-g’s picture

Despite the title of the patch filename being incorrect, this was in fact the correct patch ;).

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.