locale-rtl.css [#1040262]

Comment	File	Size	Author
#10	1040262-before.png	12.78 KB	good_man
#10	1040262-after.png	10.62 KB	good_man
#5	1040262-locale-rtl-5.patch	1.18 KB	aspilicious
	locale_rtl.patch	1.5 KB	tsi

Comment #1

tsi commented 29 January 2011 at 13:40

Issue tags:

+RTL

Adding tag

Log in or register to post comments

Comment #2

tr commented 24 May 2011 at 06:47

Version:	7.x-dev	» 8.x-dev
Status:	Needs review	» Needs work

Moving to D8.

Patch to locale.css no longer applies because of changes made by #953010: locale.css causes vertical tabs to overlap the language selection drop-down menu in node edit forms. The new locale-rtl.css file added by this patch needs to be reviewed to see that it also addresses the issues raised in #953010: locale.css causes vertical tabs to overlap the language selection drop-down menu in node edit forms.

Log in or register to post comments

honest question, if you push this to D8, when are we finally going to get RTL support in D7, we had it in D6, and we don't have it anymore, this is a major regression.
All these rtl patches need to be committed once and for all, even if only 99% perfect, they are all interdependent and every time one of them gets outdated because another css patch got committed, all or many of them go back to needs work.
RTL support in D7 is becoming a real PITA to achieve.
Someone in the Israeli community already suggested maintaining a distro with rtl patches already applied, this seems weird but we are really this close to having RTL supported and yet, the current fresh install of D7 look really bad for RTL users.

Log in or register to post comments

Comment #4

tr commented 24 May 2011 at 15:40

Issue tags:

+Needs backport to D7

Yes, we all feel the same way about the process. The discussion about how to fix it is at #1050616: Figure out backport workflow from Drupal 8 to Drupal 7.

By moving it to D8 I'm actually making it *more* likely to get into D7 as soon as possible, crazy as it seems. Anyway, since the patch no longer applies the first step, regardless of branch, is to re-roll the patch so it can be tested.

Log in or register to post comments

Comment #5

aspilicious commented 27 May 2011 at 20:08

Status	File	Size
new	1040262-locale-rtl-5.patch	1.18 KB

Rerolled, srry I'm stealing your credit with this git patch :s.

Log in or register to post comments

Comment #6

aspilicious commented 27 May 2011 at 20:08

Status:

Needs work

» Needs review

Needz review :)

Log in or register to post comments

Comment #7

tr commented 27 May 2011 at 20:36

Patch applies cleanly in D8 and D7 for me.

Now we need someone who uses RTL to test it out and see that it fixes the issue without breaking LTR. That's not me - I don't use RTL.

@tsi: Perhaps you can encourage some people in "the Israeli community" to try out this patch and post their reviews - that's going to the be quickest way to get this fixed in D8 and D7.