When the from address field is left blank in the configuration page, it is supposed to default to the site address (that is what it says under the field anyway). It doesn't though, and instead the from address is left blank, resulting in a whitescreen of death with 'Invalid address' printed on it. The mail does still get sent though.

Comments

berdir’s picture

Status: Active » Needs review
StatusFileSize
new1023 bytes

Confirmed, please try the patch.

The problem is that drupal_mail() uses isset($form) but that is only FALSE if it is NULL, not if it's an empty string.

Status: Needs review » Needs work

The last submitted patch, do_not_pass_empty_string_as_from.patch, failed testing.

berdir’s picture

Status: Needs work » Needs review
StatusFileSize
new1.11 KB

Better patch.

berdir’s picture

Version: » 7.x-1.x-dev
Status: Needs review » Patch (to be ported)

Commited, thanks for reporting.

berdir’s picture

Status: Patch (to be ported) » Fixed

Commited to 7.x too.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.