CVS edit link for davidneedham

We at Chapter Three completed a simple Drupal 6 theme which all of our theming students learn how to make in class. It's underwent several iterations since first starting the class and I think it's solid enough to give back to the community. We usually make slight improvements to the theme after every class and will continue supporting this module with those updates. We will also be expanding the amount of documentation within the theme to further facilitate the learning process.

This theme will soon be available for Drupal 7, as we are gearing up for Drupal 7 courses and our upcoming session at Drupalcon Chicago for Drupal 7 theming.

There are several other themes which I have produced for both Drupal 6 and 7 which I would like to contribute once they have matured. There are also several themer-friendly modules which we use in house which I would like to polish and contribute this year.

CommentFileSizeAuthor
#6 acme-screenshot-640x400_v1.1.png29.46 KBdavidneedham
#6 acme.zip54.58 KBdavidneedham
#3 acme-screenshot-640x400.png28.56 KBdavidneedham
#3 acme.zip53.97 KBdavidneedham
#1 Acme.zip53.95 KBdavidneedham

Comments

davidneedham’s picture

davidneedham
he/him
commented
Component: Miscellaneous » new project application
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new Acme.zip53.95 KB

Thank you for taking the time to review my application. The Acme theme is compressed and attached.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work

Hello, and thank you for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

I will report here a little checklist:

  • The code needs to follow the coding standards; check in particular the format used for the control structures, and the name given to PHP variables, Drupal persistent variables, functions defined from the module.
  • Files available from third-party sites should not be included within the module/theme. This is particularly true for files that are not licensed under GPL License v2, but it is also true for files that are licensed under the same license used by Drupal.
  • The license file should not be included as well; the packaging script already include that file. In any cases, the code for modules/themes committed in drupal.org repository needs to be released under the same license used by Drupal; any compatible license is not allowed.
  • Check the code passes the Coder validation.

As per requirements, the motivation message should include also a screenshot of the theme (at least 640x400 pixels), and (when possible) a link to a working demo site; for modules, it should include also a comparison with the existing solutions.

davidneedham’s picture

davidneedham
he/him
commented
StatusFileSize
new acme.zip53.97 KB
new acme-screenshot-640x400.png28.56 KB

The screenshot is attached.

I fixed a bug. The new zip of the theme is also attached.

Demo site coming soon.

davidneedham’s picture

davidneedham
he/him
commented

The theme can be viewed in action at: http://unrealnighthawk.gotpantheon.com/node/1.

Let me know if there is anything else I need to do.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
davidneedham’s picture

davidneedham
he/him
commented
StatusFileSize
new acme.zip54.58 KB
new acme-screenshot-640x400_v1.1.png29.46 KB

Attached v1.1 which includes some minor bugfixes and some changes of colors to improve the contrast ratio to conform to WCAG 2.0 AA criteria.

I also attached a new 640x400 screenshot to reflect these changes.

Unfortunately my hosting also changed. Here's the new URL: http://acme.enjoycreativity.com/node/11

Let me know if there's anything else you need. Thanks!

arianek’s picture

arianek commented
Status: Needs review » Postponed

Hi. Please read all the following and the links provided as this is very important information about your CVS Application:

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications

  • The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
  • Or if your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.
davidneedham’s picture

davidneedham
he/him
commented
Status: Postponed » Needs review

This project is moved to the git sandbox. The most recent Drupal 6 version is in the 6.x-1.x branch of the project. The (unfinished) Drupal 7 version is in the master branch. I can imagine you will want both functioning before my request is approved, so I will post as soon as the D7 version is ready. In the meantime, I would appreciate feedback and input on if my process using git is correct (this is my first time using git).

http://drupal.org/sandbox/davidneedham/1094004

Thank you!

davidneedham’s picture

davidneedham
he/him
commented

I committed an improved version for D7 which has fixed many of the problems that the initial commit had. There are still a few outstanding issues to make it match the D6 version, but that will be coming along soon.

joshk’s picture

joshk commented

Probably don't need the .DS_Store file in there.

Otherwise this looks good to me. I can vouch for David's merit and good intentions.

zirafa’s picture

zirafa commented

+1, Looks good to me. I'd breakout the $submitted more (move more of it directly into the node.tpl.php file) more but that is more of a stylistic preference than anything else.

davidneedham’s picture

davidneedham
he/him
commented

Thanks joshk, I made a commit without the .DS_Store.

Thank you too zirafa - I recently did some work on $submitted. I still have some things in my queue to take care of for that, but let me know what you think.

joshk’s picture

joshk commented
Status: Needs review » Closed (fixed)

I went ahead w/this since the code is good and it got a few other thumbs-ups.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
Status: Closed (fixed) » Fixed

I am giving credits to the users who participated in this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.