CVS edit link for carvalhar

I have a module that i'd like to share. This module creates a rule action to be used with other module, user forced terms.

And i'd like to submit some free themes also.

CommentFileSizeAuthor
#4 rules_forced_term.zip1.21 KBcarvalhar

Comments

carvalhar’s picture

carvalhar commented
Component: Miscellaneous » miscellaneous

The module is attached at this post:
http://drupal.org/node/1034118#comment-3981836

carvalhar’s picture

carvalhar commented

My profile says "You are not authorized to access this page." at project page.
What should i do?

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

Hello, and thank you for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

I will report here a little checklist:

  • The code needs to follow the coding standards; check in particular the format used for the control structures, and the name given to PHP variables, Drupal persistent variables, functions defined from the module.
  • Files available from third-party sites should not be included within the module/theme. This is particularly true for files that are not licensed under GPL License v2, but it is also true for files that are licensed under the same license used by Drupal.
  • The license file should not be included as well; the packaging script already include that file. In any cases, the code for modules/themes committed in drupal.org repository needs to be released under the same license used by Drupal; any compatible license is not allowed.
  • Check the code passes the Coder validation.

As per requirements, the motivation should include more than two sentences (the exact words are a few paragraphs) that describe the module features, and compare it with the existing solutions.
The archive needs then to be uploaded in a comment here.

carvalhar’s picture

carvalhar commented
Issue tags: +rules integration, +rules
StatusFileSize
new rules_forced_term.zip1.21 KB

Hi,

The code is attached and the description is here:

This module is very simple: it creates a Rules action to specify a term to a user.
Dependencies:
1 - Rules (http://drupal.org/project/rules)
2- Forced Term (http://drupal.org/project/user_force_term)

Forced term is a module who force all content submitted by a user to be associated with a term from a taxonomy and hides th vocabulary from node/add.

Rules allows site administrators to define conditionally executed actions based on occurring events.

My module will provide an action, so when you are setting a new rule, you'll find a new action "Force term to a user" at User group, under Rules options. This action has two arguments, a term and a user, and these variables can be replaced normally by Rules module.

It's really very simple, but maybe it will be useful to someone else also.

Hope everything is ok now :)

Bye
Carlos

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Component: miscellaneous » new project application
Status: Postponed (maintainer needs more info) » Needs review
Issue tags: -rules integration, -rules +Module review
carvalhar’s picture

carvalhar commented

Hey,

Do i have to do anything else? But what exactly?

About "Status:postponed (maintainer needs more info)" and "needs review"...what i need to do?

carvalhar’s picture

carvalhar commented

Sorry to be boring...but what i need to review?
I think i did as asked at #3.

What should i change/review?

Thanks,
Carlos

zzolo’s picture

zzolo commented
Status: Needs review » Postponed

Hi. Please read all the following and the links provided as this is very important information about your CVS Application:

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications

  • The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
  • Or if your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
Status: Postponed » Closed (won't fix)

As per previous comment, I am setting this issue to won't fix.
Since new users can now create full projects, applications have a different purpose and they are handled on a different issue queue. See Apply for permission to opt into security advisory coverage for more information.