Using clean D7 stable and latest simplenews 7.x-1.x-dev and PHP 5.3.1. Create two nodes, one of a blog type and another one of a simplenews enabled content type. When visiting any page where both nodes will be loaded (for example admin/content/node) PHP will give fatal error:

Fatal error: Cannot access empty property in /drupal/sites/all/modules/simplenews/simplenews.module on line 383

Problem is in simplenews_node_load() hook - if it gets multiple mixed nodes (some which are simplenews enabled and others that are not) it will ignore this case and call simplenews_newsletter_defaults() for each node.

CommentFileSizeAuthor
#1 simplenews-1034270.patch914 bytespivica

Comments

pivica’s picture

Status: Active » Needs review
StatusFileSize
new914 bytes

Here is a patch.

miro_dietiker’s picture

Status: Needs review » Fixed

Committed, thx.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.