There is some leftover debug code in ensure_my_table() that relies on Devel module and should be remove. Patch attached.

CommentFileSizeAuthor
remove_debug_code.patch793 bytesgdd

Comments

dawehner’s picture

dawehner
Primary language German
commented

I don't see a reason for this.

vpr_trace is a safe function and more important it's there since a long time, in 6.x, too.

merlinofchaos’s picture

merlinofchaos commented

Yes, but it calls an exit. That's just bad. Plus, it's vaguely possible that a query won't actually have ensure_table() -- this makes the handlers safe if it doesn't. So I agree with this patch (and should be for 6.x as well)

gdd’s picture

gdd
he/him
Primary language English
Location Portland, OR
commented

Yes I encountered this while writing handlers for a custom query plugin accessing remote data. The other bad part is it relies on dpr() which bombs if you don't have devel installed (which I didn't).

dawehner’s picture

dawehner
Primary language German
commented
Version: 7.x-3.x-dev » 6.x-3.x-dev

Move to 6.x first

dawehner’s picture

dawehner
Primary language German
commented

I'm wondering whether a vpr would be logical here.

vpr('Method "ensure_my_table" doesn't exist') or something like this.
This would help people,... at least in 6.x-3.x

merlinofchaos’s picture

merlinofchaos commented

Yes I think it would.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Done in 7.x and 6.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.