Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.There is some leftover debug code in ensure_my_table() that relies on Devel module and should be remove. Patch attached.
| Comment | File | Size | Author |
|---|---|---|---|
| remove_debug_code.patch | 793 bytes | gdd | |
Comments
Comment #1
dawehnerI don't see a reason for this.
vpr_trace is a safe function and more important it's there since a long time, in 6.x, too.
Comment #2
merlinofchaos CreditAttribution: merlinofchaos commentedYes, but it calls an exit. That's just bad. Plus, it's vaguely possible that a query won't actually have ensure_table() -- this makes the handlers safe if it doesn't. So I agree with this patch (and should be for 6.x as well)
Comment #3
gddYes I encountered this while writing handlers for a custom query plugin accessing remote data. The other bad part is it relies on dpr() which bombs if you don't have devel installed (which I didn't).
Comment #4
dawehnerMove to 6.x first
Comment #5
dawehnerI'm wondering whether a vpr would be logical here.
vpr('Method "ensure_my_table" doesn't exist') or something like this.
This would help people,... at least in 6.x-3.x
Comment #6
merlinofchaos CreditAttribution: merlinofchaos commentedYes I think it would.
Comment #7
merlinofchaos CreditAttribution: merlinofchaos commentedDone in 7.x and 6.x